Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kapakana: 1.001 #8592

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Kapakana: 1.001 #8592

wants to merge 1 commit into from

Conversation

aaronbell
Copy link
Collaborator

Confirmed addition of comma-han (3001)

Resolves #6314

Fix also submitted upstream.

Confirming addition of Comma Han glyph, and fixing sources to enable the build system to work again.
Copy link

FontBakery report

fontbakery version: 0.13.0a5

Check results

[28] Kapakana[wght].ttf
🔥 FAIL Ensure the font supports case swapping for all its glyphs.
  • 🔥 FAIL

    The following glyphs lack their case-swapping counterparts:

Glyph present in the font Missing case-swapping counterpart
U+0137: LATIN SMALL LETTER K WITH CEDILLA U+0136: LATIN CAPITAL LETTER K WITH CEDILLA
U+0154: LATIN CAPITAL LETTER R WITH ACUTE U+0155: LATIN SMALL LETTER R WITH ACUTE
[code: missing-case-counterparts]
🔥 FAIL Font contains '.notdef' as its first glyph?
  • 🔥 FAIL

    The '.notdef' glyph should contain a drawing, but it is blank.


    [code: notdef-is-blank]
🔥 FAIL Ensure smart dropout control is enabled in "prep" table instructions.
  • 🔥 FAIL

    The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script.


    [code: lacks-smart-dropout]
🔥 FAIL Are there unwanted tables?
  • 🔥 FAIL

    The following unwanted font tables were found:

  • DSIG - This font has a digital signature (DSIG table) which is only required - even if only a placeholder - on old programs like MS Office 2013 in order to work properly. The current recommendation is to completely remove the DSIG table.

They can be removed with the 'fix-unwanted-tables' script provided by gftools.

[code: unwanted-tables]
🔥 FAIL Space and non-breaking space have the same width?
  • 🔥 FAIL

    Space and non-breaking space have differing width: The space glyph named space is 300 font units wide, non-breaking space named (uni00A0) is 725 font units wide, and both should be positive and the same. GlyphsApp has "Sidebearing arithmetic" (https://glyphsapp.com/tutorials/spacing) which allows you to set the non-breaking space width to always equal the space width.


    [code: different-widths]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Check font follows the Google Fonts CJK vertical metric schema
  • 🔥 FAIL

    OS/2 fsSelection bit 7 must be disabled


    [code: bad-fselection-bit7]

  • 🔥 FAIL

    OS/2.sTypoAscender is "680" it should be 880


    [code: bad-OS/2.sTypoAscender]

  • 🔥 FAIL

    OS/2.sTypoDescender is "-320" it should be -120


    [code: bad-OS/2.sTypoDescender]

  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.1-1.4x of the font's upm. This font has 1.0x


    [code: bad-hhea-range]

🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x2122 (TRADE MARK SIGN)

[code: missing-codepoints]

⚠️ WARN Does the font contain chws and vchw features?
⚠️ WARN Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value
  • ⚠️ WARN

    GPOS table lacks kerning information.


    [code: lacks-kern-info]
⚠️ WARN Ensure variable fonts include an avar table.
  • ⚠️ WARN

    This variable font does not have an avar table. Most variable fonts should include an avar table to correctly define axes progression rates.


    [code: missing-avar]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 350 among a set of 3 math glyphs.
    The following math glyphs have a different width, though:

Width = 335: less

Width = 382: equal

Width = 386: logicalnot

Width = 447: plusminus

Width = 343: multiply

Width = 357: divide

[code: width-outliers]
⚠️ WARN Check there are no overlapping path segments
  • ⚠️ WARN

    The following glyphs have overlapping path segments:

* uni3043 (U+3043): B<<158.0,155.0>-<158.0,155.0>-<158.0,155.0>> has the same coordinates as a previous segment.

* uni3046 (U+3046): B<<196.0,497.0>-<196.0,497.0>-<196.0,497.0>> has the same coordinates as a previous segment.

* uni305F (U+305F): B<<150.0,160.0>-<150.0,160.0>-<150.0,160.0>> has the same coordinates as a previous segment.

* uni3060 (U+3060): B<<150.0,160.0>-<150.0,160.0>-<150.0,160.0>> has the same coordinates as a previous segment.

* uni3094 (U+3094): B<<196.0,497.0>-<196.0,497.0>-<196.0,497.0>> has the same coordinates as a previous segment.

[code: overlapping-path-segments]

⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- CR

[code: unreachable-glyphs]

⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/kapakana does not have an article.


    [code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+03BC GREEK SMALL LETTER MU: try adding one of: greek, math
  • U+FB00 LATIN SMALL LIGATURE FF: not included in any glyphset definition
  • U+FB01 LATIN SMALL LIGATURE FI: not included in any glyphset definition

Or you can add the above codepoints to one of the subsets supported by the font: japanese, latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Check copyright namerecords match license file.
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* uni3047 (U+3047) has a counter-clockwise outer contour

[code: ccw-outer-contour]

⚠️ WARN Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0A - Use grayscale rendering - Use smoothing along multiple axes with ClearType®

[code: ranges]
  • ⚠️ WARN

    The gasp range 0xFFFF value 0x0A should be set to 0x0F.


    [code: unset-flags]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/kapakana


    [code: family-path]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/kapakana/Kapakana[wght].ttf
Dehinted Size 178.2kb
Hinted Size 178.2kb
Increase 0 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 8 12 55 9 168 0
0% 0% 3% 5% 22% 4% 67% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@aaronbell aaronbell added the I Small Fix bugs fixed but nothing added label Nov 26, 2024
@emmamarichal
Copy link
Collaborator

emmamarichal commented Nov 27, 2024

@aaronbell

Fontbakery review

Some suggestions to fix some fails and warns:

🔥 FAIL Ensure the font supports case swapping for all its glyphs.
-> two glyphs to generate (U+0136 and U+0155)

🔥 FAIL Font contains '.notdef' as its first glyph?
-> Needs a rectangle in .notdef

🔥 FAIL Are there unwanted tables?
-> I'm not familiar with that fail, should we fix it?

🔥 FAIL Space and non-breaking space have the same width?
-> spacing value to change

🔥 FAIL Check font follows the Google Fonts CJK vertical metric schema
-> I know that the CJK fonts have particular v-metrics, that are not always follow the GF specs, but I don't know about the Use type metrics parameter (bit7): maybe better to add it?

🔥 FAIL Check Google Fonts glyph coverage.
-> Can be fixed by adding the trademark

⚠️ WARN Check font contains no unreachable glyphs
-> Can be fixed by removing CR (not mandatory anymore)

⚠️ WARN Check copyright namerecords match license file.
-> update the url from 'https://scripts.sil.org/OFL' to 'https://openfontlicense.org/'.

@emmamarichal
Copy link
Collaborator

Outlines review

@aaronbell
I didn't see any big issues! :)

I'm just wondering if the space isn't too large, same for some of the punctuation spacing:

Screenshot 2024-11-27 at 11 55 56

I also noted this alignement issue (string: Âaj d´fhiacha)

Screenshot 2024-11-27 at 11 57 36

@emmamarichal emmamarichal added the -- Needs confirmation from upstream or onboarder label Nov 27, 2024
@emmamarichal emmamarichal self-requested a review November 27, 2024 14:29
@emmamarichal emmamarichal added the -- Needs Upstream Resolution Upstream fix required before moving forward label Nov 28, 2024
@aaronbell
Copy link
Collaborator Author

@emmamarichal Out of interest, in Âaj d´fhiacha, is using the legacy acute glyph there a common scenario?

@aaronbell
Copy link
Collaborator Author

🔥 FAIL Check font follows the Google Fonts CJK vertical metric schema
-> I know that the CJK fonts have particular v-metrics, that are not always follow the GF specs, but I don't know about the Use type metrics parameter (bit7): maybe better to add it?

This is a weird font wherein it is technically CJK, but does not align to CJK metrics because it is acting more like a Latin font. To that end, I've enabled useTypoMetrics, and set the metrics accordingly...

@emmamarichal
Copy link
Collaborator

@aaronbell

Out of interest, in Âaj d´fhiacha, is using the legacy acute glyph there a common scenario?

I'm not sure tbh, I'll raise that question, and if it's not useful anymore, we should upgrade our proofs!

To that end, I've enabled useTypoMetrics, and set the metrics accordingly...

Perfect, thanks a lot!

Ping me when the PR is updated, I'll give a last review (if the designer makes some changes for the punctuation spacing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Needs confirmation from upstream or onboarder -- Needs Upstream Resolution Upstream fix required before moving forward I Small Fix bugs fixed but nothing added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing glyph in Kapakana
2 participants