-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kapakana: 1.001 #8592
base: main
Are you sure you want to change the base?
Kapakana: 1.001 #8592
Conversation
Confirming addition of Comma Han glyph, and fixing sources to enable the build system to work again.
FontBakery reportfontbakery version: 0.13.0a5 Check results[28] Kapakana[wght].ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL Font contains '.notdef' as its first glyph?
🔥 FAIL Ensure smart dropout control is enabled in "prep" table instructions.
🔥 FAIL Are there unwanted tables?
They can be removed with the 'fix-unwanted-tables' script provided by gftools. [code: unwanted-tables]🔥 FAIL Space and non-breaking space have the same width?
🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Check font follows the Google Fonts CJK vertical metric schema
🔥 FAIL Check Google Fonts glyph coverage.
[code: missing-codepoints]
|
ofl/kapakana/Kapakana[wght].ttf | |
---|---|
Dehinted Size | 178.2kb |
Hinted Size | 178.2kb |
Increase | 0 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- gasp
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/nagamaki008/kapakana
[code: url-found]
[1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 8 | 12 | 55 | 9 | 168 | 0 |
0% | 0% | 3% | 5% | 22% | 4% | 67% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Fontbakery reviewSome suggestions to fix some fails and warns: 🔥 FAIL Ensure the font supports case swapping for all its glyphs. 🔥 FAIL Font contains '.notdef' as its first glyph? 🔥 FAIL Are there unwanted tables? 🔥 FAIL Space and non-breaking space have the same width? 🔥 FAIL Check font follows the Google Fonts CJK vertical metric schema 🔥 FAIL Check Google Fonts glyph coverage.
|
Outlines review@aaronbell I'm just wondering if the I also noted this alignement issue (string: |
@emmamarichal Out of interest, in |
This is a weird font wherein it is technically CJK, but does not align to CJK metrics because it is acting more like a Latin font. To that end, I've enabled useTypoMetrics, and set the metrics accordingly... |
I'm not sure tbh, I'll raise that question, and if it's not useful anymore, we should upgrade our proofs!
Perfect, thanks a lot! Ping me when the PR is updated, I'll give a last review (if the designer makes some changes for the punctuation spacing) |
Confirmed addition of
comma-han
(3001)Resolves #6314
Fix also submitted upstream.