-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matemasie: Version 1.001; ttfautohint (v1.8.4.7-5d5b) added #7875
Conversation
FontBakery reportfontbakery version: 0.12.7 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] Matemasie-Regular.ttfAll other checks[22] Matemasie-Regular.ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL Checking OS/2 usWinAscent & usWinDescent.
🔥 FAIL Name table records must not have trailing spaces.
🔥 FAIL Checking with fontTools.ttx
🔥 FAIL Space and non-breaking space have the same width?
🔥 FAIL METADATA.pb font.name and font.full_name fields match the values declared on the name table?
🔥 FAIL METADATA.pb font.name value should be same as the family name declared on the name table.
🔥 FAIL Is this a proper HTML snippet?
🔥 FAIL Check copyright namerecords match license file.
🔥 FAIL Check font names are correct
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 10 | 8 | 71 | 7 | 152 | 0 |
0% | 0% | 4% | 3% | 29% | 3% | 61% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
@nathan-williams quite a few fails need addressing before we can merge this. |
Updated |
a96187c
to
def1d8d
Compare
FontBakery reportfontbakery version: 0.12.7 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] Matemasie-Regular.ttfAll other checks[14] Matemasie-Regular.ttf🔥 FAIL Checking with fontTools.ttx
🔥 FAIL Is this a proper HTML snippet?
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 8 | 70 | 7 | 161 | 0 |
0% | 0% | 1% | 3% | 28% | 3% | 65% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
def1d8d
to
1616b8c
Compare
Updated |
FontBakery reportfontbakery version: 0.12.7 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] Matemasie-Regular.ttfAll other checks[13] Matemasie-Regular.ttf🔥 FAIL Is this a proper HTML snippet?
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 1 | 8 | 70 | 7 | 162 | 0 |
0% | 0% | 0% | 3% | 28% | 3% | 65% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Looking good! Could you add description to the article file please? |
Updated |
1616b8c
to
b116319
Compare
FontBakery reportfontbakery version: 0.12.7 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] Matemasie-Regular.ttf🔥 FAIL METADATA.pb: Validate family.minisite_url field.
All other checks[13] Matemasie-Regular.ttf🔥 FAIL Is this a proper HTML snippet?
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 8 | 70 | 6 | 162 | 0 |
0% | 0% | 1% | 3% | 28% | 2% | 65% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Updated |
b116319
to
d61aad1
Compare
FontBakery reportfontbakery version: 0.12.7 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [1] Matemasie-Regular.ttfAll other checks[13] Matemasie-Regular.ttf🔥 FAIL Is this a proper HTML snippet?
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 1 | 8 | 70 | 6 | 163 | 0 |
0% | 0% | 0% | 3% | 28% | 2% | 66% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Updated |
d61aad1
to
00a0e2e
Compare
FontBakery reportfontbakery version: 0.12.7 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [1] Matemasie-Regular.ttfAll other checks[13] Matemasie-Regular.ttf🔥 FAIL Is this a proper HTML snippet?
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 1 | 8 | 70 | 6 | 163 | 0 |
0% | 0% | 0% | 3% | 28% | 2% | 66% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
I'm not seeing where it is that this check is looking. The DESCRIPTION and ARTICLE html files are not missing tags (AFAICT...). From context it also seems like the tag that the check is complaining about is a <p>, but perhaps it means something else? |
The Article file is here, https://github.com/google/fonts/pull/7875/files#diff-5d21c92f508684d5a272559aa366d1a491ef96f1e057b6908d57c289f107973b and its content is the placeholder "N/A". Please populate the file. |
The ARTICLE file is there: https://github.com/YADAMSS/Matemasie-Font/blob/main/ARTICLE.en_us.html ... it seems like perhaps the packager isn't grabbing the latest commit? I thought it was automatically going to do that (the packager was run from the same machine where the local commit was made in the upstream repo). |
The packager uses what is specified in the metadata file. It needs to include the source information for the article. See this |
Thanks for replying; I'm definitely glad to know there's a straightforward fix. But booyhowdy, the error message sure does not point a person in the right direction at all.... Clarifying that would really make a big usability improvement for people. Couple of quick thoughts there -- first, the root issue it's finding is actually the packager command not seeing a file where it expects to, but the error shown in the check is from FontBakery, about a missing HTML tag. If the packager needs the file to exist, then it could report that in its own output on the terminal, with the other stuff it reports. That would definitely be clearer, but it'd also be more helpful practically, because it'd let the user make that fix immediately, instead of pushing it to the PR and waiting to see the check output. (Secondarily, if the presence of the file is mandatory, then could the packager look for it by name (like it does with OFL.txt) and handle it when constructing the boilerplate METADATA.pb?) Also, separately, can a list of the required files please be added to the documentation? If Article is required, and it has to be specified in the .pb file, that goes somewhere. This detail is not on the page about the Article and not on the page about METADATA.pb. I looked in both places trying to figure out the fix; I don't know when I would have found it just by searching on my own. |
Updated |
00a0e2e
to
ac5d7f0
Compare
FontBakery reportfontbakery version: 0.12.8 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] Matemasie-Regular.ttfAll other checks[13] Matemasie-Regular.ttf🔥 FAIL Is this a proper HTML snippet?
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 8 | 71 | 6 | 164 | 0 |
0% | 0% | 1% | 3% | 28% | 2% | 65% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Updated |
ac5d7f0
to
8b4f108
Compare
FontBakery reportfontbakery version: 0.12.8 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] Matemasie-Regular.ttfAll other checks[13] Matemasie-Regular.ttf🔥 FAIL Is this a proper HTML snippet?
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 8 | 71 | 6 | 164 | 0 |
0% | 0% | 1% | 3% | 28% | 2% | 65% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Taken from the upstream repo https://github.com/YADAMSS/Matemasie-Font at commit YADAMSS/Matemasie-Font@05f20fb.
Updated |
8b4f108
to
f4e074a
Compare
FontBakery reportfontbakery version: 0.12.8 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] Matemasie-Regular.ttfAll other checks[12] Matemasie-Regular.ttf
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 1 | 8 | 71 | 6 | 165 | 0 |
0% | 0% | 0% | 3% | 28% | 2% | 66% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
|
Re-reading this now, it looks like the packager already included this feature at this PR time. AFAIR, it throws a message on the terminal about it. |
FontBakery reportfontbakery version: 0.12.8 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] Matemasie-Regular.ttfAll other checks[12] Matemasie-Regular.ttf
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 1 | 8 | 71 | 6 | 165 | 0 |
0% | 0% | 0% | 3% | 28% | 2% | 66% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
@n8willis thank you very much. LGTM |
@m4rc1e Can you add it to the traffic jam as well? I don't have permissions to access that |
Done |
Hi @n8willis, could you ask the designer to fill out the designer profile form, so we can add him/her to the catalog? |
Sure thing @emmamarichal |
Taken from the upstream repo https://github.com/YADAMSS/Matemasie-Font at commit YADAMSS/Matemasie-Font@f8b28b0.
PR Checklist: