Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability: Define acronyms before use #22

Open
austenwho opened this issue Mar 24, 2020 · 3 comments
Open

Readability: Define acronyms before use #22

austenwho opened this issue Mar 24, 2020 · 3 comments
Assignees

Comments

@austenwho
Copy link

austenwho commented Mar 24, 2020

It is already noted in the github repo that CL doesn't have any meaning outside of Google, and I'm glad that it is defined in the repo for those of us outside of the Google ecosystem.

I would like to make a suggestion that would solve this problem for people outside of Google (the documents have general appeal), as well as anyone within Google but new to the Google way of doing things.

  1. Always define an acronym before using it. It is easy enough to say: "When starting to review a new change list (CL).." This way nobody has to feel like they're dumb for missing something so simple as what a CTLG is or a VA is, or make sure you STL that. It's frustrating when acronyms are used with no definition anywhere in sight. Did you miss it? Was it in that paragraph up top? Maybe it is defined in one of the other pages in the table of contents.... It is unnecessarily wasted time for the reader to hunt down what terms you are using.

  2. Include a glossary.

Just my $0.02

I really like the documents otherwise. Lots of good lessons, looking forward to sharing them within my organization.

@ninachen
Copy link
Collaborator

Yes, agree. Presently, there's a terminology section here: https://github.com/google/eng-practices#terminology

but enough people have missed it that we could make this clearer.

@veeara282
Copy link

It would also help to mention roughly equivalent terms used by most organizations, such as "pull request" and "merge request."

@xdumaine
Copy link

xdumaine commented Feb 4, 2021

I'll add that I couldn't even find that terminology page. Having acronyms link to that page in a number of places would probably be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants