Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matlab implementation is out of date with modern matlab #5

Open
sedurCode opened this issue Feb 11, 2021 · 3 comments
Open

Matlab implementation is out of date with modern matlab #5

sedurCode opened this issue Feb 11, 2021 · 3 comments

Comments

@sedurCode
Copy link
Contributor

Several changes to matlab have made the matlab scripts for CARFAC slightly out of date.
An example of this is the use of wavread and wavwrite which mathworks deprecated a couple years ago in favour of audioread and audiowrite. The example code is also slightly platform specific, but the changes to make it platform agnostic are minimal.

sedurCode added a commit to sedurCode/carfac that referenced this issue Feb 11, 2021
sedurCode added a commit to sedurCode/carfac that referenced this issue Mar 1, 2021
# This is the 1st commit message:

9 update cpp build settings and gtest compatability

# This is the commit message google#2:

Revert back to test suite when using a more uptodate version of gtest than supplied by apt-get

# This is the commit message google#3:

actually version 1.8

# This is the commit message google#4:

scons instructions update

# This is the commit message google#5:

google#5 Now matlab scripts run correctly with modern matlab

# This is the commit message google#6:

Update SConstruct to be python 3 compatible.
sedurCode added a commit to sedurCode/carfac that referenced this issue Mar 1, 2021
# This is the 1st commit message:

9 update cpp build settings and gtest compatability

# This is the commit message google#2:

Revert back to test suite when using a more uptodate version of gtest than supplied by apt-get

# This is the commit message google#3:

actually version 1.8

# This is the commit message google#4:

scons instructions update

# This is the commit message google#5:

google#5 Now matlab scripts run correctly with modern matlab

# This is the commit message google#6:

Update SConstruct to be python 3 compatible.
# This is the commit message google#7:

revert matlab-related changes

# This is the commit message google#8:

whitespace
@dicklyon
Copy link
Collaborator

dicklyon commented Jul 14, 2022 via email

@Pitaya-Lychee
Copy link

Pitaya-Lychee commented Jul 14, 2022 via email

@dicklyon
Copy link
Collaborator

dicklyon commented Jul 14, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants