Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CTAP 2.1 flag #248

Closed
wants to merge 7 commits into from
Closed

Conversation

kaczmarczyck
Copy link
Collaborator

In our new develop branch, we drop support for CTAP 2.0 separately from CTAP 2.1.

This is related to #106 and makes #128 much less important since the amount of cfg statements is significantly reduced. (I leave it to @jmichelp if we want to close #128.)

  • Tests pass
  • Appropriate changes to README are included in PR

@kaczmarczyck kaczmarczyck requested a review from jmichelp January 6, 2021 18:28
@kaczmarczyck kaczmarczyck self-assigned this Jan 6, 2021
@google-cla google-cla bot added the cla: yes label Jan 6, 2021
@kaczmarczyck
Copy link
Collaborator Author

This will be rebased after #249 is merged.

@kaczmarczyck
Copy link
Collaborator Author

Closing this PR to create a new PR against develop.

@kaczmarczyck kaczmarczyck deleted the remove-flag-2-1 branch January 8, 2021 11:43
@kaczmarczyck kaczmarczyck mentioned this pull request Jan 8, 2021
2 tasks
@jmichelp
Copy link
Collaborator

jmichelp commented Jan 8, 2021

All you needed to do was to edit the PR branch :)

@kaczmarczyck
Copy link
Collaborator Author

I thought this could be possible, but didn't see where :)

@jmichelp
Copy link
Collaborator

jmichelp commented Jan 8, 2021

Click the "edit" button next to the name of the PR. Beside changing the title it also enables the dropdown selectors for the branches. That's how I moved all opened PR yesterday

@kaczmarczyck
Copy link
Collaborator Author

Ah thanks. I saw the name change only.

@kaczmarczyck
Copy link
Collaborator Author

Oh, actually that doesn't work for me. Maybe I need a higher access tier?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#cfg in macros
3 participants