Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disentanglement metrics don't seem to work with continuous factors #25

Open
asross opened this issue Mar 30, 2020 · 0 comments
Open

Disentanglement metrics don't seem to work with continuous factors #25

asross opened this issue Mar 30, 2020 · 0 comments

Comments

@asross
Copy link

asross commented Mar 30, 2020

I might be misunderstanding (e.g. perhaps all the ground-truth factors are meant to be discretized), but it seems like all of the metrics require latent factors to be discrete, e.g. using a classifier rather than a regressor for DCI. This is a bit inconvenient for users who would like to use your library to evaluate disentanglement solely given matrices of continuous latents and ground truth factors (without using the representation_function API). I know it's a design choice rather than a bug, but I'd still like to make the suggestion that it would be helpful for future users if you supported this use case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant