Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Please replace tf.layers with tf.keras.layers #1

Open
sibyjackgrove opened this issue Feb 14, 2019 · 2 comments
Open

Comments

@sibyjackgrove
Copy link

In the official TensorFlow blog posts, it was said that tf.layers would be depreciated and tf.keras.layers would be the preferred method. However in architectures.py tf.layers has been used everywhere to create the encoder and decoder models. It would be great if these could be modifed to use tf.keras.layers since others would be able to reuse the code without worry.

#feature request

@obachem
Copy link
Collaborator

obachem commented Feb 15, 2019

Our initial focus has been on open-sourcing the exact architectures/implementations that can be used to reproduce the experiments in the study "Challenging Common Assumptions in the Unsupervised Learning of Disentangled Representations" (https://arxiv.org/abs/1811.12359). However, we are looking into ways to make sure disentanglement_lib is compatible with the upcoming changes to TensorFlow. In the meantime, it is very easy to define your own encoder/decoder architectures and to use them via gin with disentanglement_lib.

@sibyjackgrove
Copy link
Author

Ok, thanks. Good to hear that you have compatibility with tf 2.0 on the radar. I will try writing my own architecture in mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants