x/mobile: build failing when using go modules #27234

mirza-s · 2018-08-26T11:24:26Z

What version of Go are you using (`go version`)?

go version go1.11 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (`go env`)?

GOARCH="amd64"
GOBIN="/Users/mbp/go/bin"
GOCACHE="/Users/mbp/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/mbp/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/mbp/wrk/src/libfp/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/nt/0hzfppd92jvbk99fhvnhy8ph0000gn/T/go-build526348344=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

gomobile bind -target=android .

What did you expect to see?

Normal build as when building inside GOPATH

What did you see instead?

gomobile: go build -buildmode=c-shared -o=/var/folders/nt/0hzfppd92jvbk99fhvnhy8ph0000gn/T/gomobile-work-327189385/android/src/main/jniLibs/armeabi-v7a/libgojni.so gobind failed: exit status 1
go: finding github.com/dustin/go-humanize v0.0.0-20180713052910-9f541cc9db5d
go: finding golang.org/x/mobile v0.0.0-20180808221059-bceb7ef27cc6
can't load package: package gobind: unknown import path "gobind": cannot find module providing package gobind

The text was updated successfully, but these errors were encountered:

hajimehoshi · 2018-09-10T03:38:25Z

Hi, what's going on this?

wangyun · 2018-09-19T00:31:38Z

I have the same issue but with some different error message:

gomobile: /home/wangyun/dev/gopath/bin/gobind -lang=go,java -outdir=/tmp/gomobile-work-948078978 testaar failed: exit status 1
unable to import bind: cannot find package "golang.org/x/mobile/bind" in any of:
/home/wangyun/dev/software/go/src/golang.org/x/mobile/bind (from $GOROOT)
/home/wangyun/dev/gopath/src/golang.org/x/mobile/bind (from $GOPATH)
unable to import bind: cannot find package "golang.org/x/mobile/bind" in any of:
/home/wangyun/dev/software/go/src/golang.org/x/mobile/bind (from $GOROOT)
/home/wangyun/dev/gopath/src/golang.org/x/mobile/bind (from $GOPATH)
unable to import bind/java: cannot find package "golang.org/x/mobile/bind/java" in any of:
/home/wangyun/dev/software/go/src/golang.org/x/mobile/bind/java (from $GOROOT)
/home/wangyun/dev/gopath/src/golang.org/x/mobile/bind/java (from $GOPATH)

I'm using go 1.11 and updated gomobile, gobind to the latest version.

evenardo · 2018-10-10T03:24:43Z

'''
env go111module=off gomobile bind
'''
it's will temporarily worked fine

myitcv · 2018-11-14T05:24:07Z

cc @eliasnaur - some time has elapsed since this issue and I'm not sufficiently up to speed to know whether mobile is now modules-aware.

eliasnaur · 2018-11-14T08:23:45Z

Gomobile has not been converted. ons. 14. nov. 2018 06.25 skrev Paul Jolly <[email protected]>:

…

cc @eliasnaur <https://github.com/eliasnaur> - some time has elapsed since this issue and I'm not sufficiently up to speed to know whether mobile is now modules-aware. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#27234 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAgCDBmUNHJxqpeDT1Njw9kvu-CzgzI3ks5uu6lJgaJpZM4WMvnl> .

kingwill101 · 2018-11-28T12:24:09Z

is there work currently being done on this front?

eliasnaur · 2018-11-28T12:45:01Z

Not yet, at least not from my side. Partly because of time available, partly because I prefer to wait for module support to mature (GO111MODULE always on, the go/packages package feature complete and so on), but the main stumbling block is that I can't see the gomobile bind mode work as usual in module mode, at least not in its current form.
The problem is vendoring: gomobile bind generates a main package that in turn imports the packages you want to export to Java or Objective C. That works well in GOPATH mode, but not in module mode. Suppose gomobile bind in module mode generates a module containing a main package and your module as a dependency. Then, because vendored packages are only respected for the main module, any vendored packages from your module will be ignored by the go tool.
Perhaps some form of #26640 will help gomobile. Perhaps gomobile bind should work in a different way. I haven't thought that much about it.

eliasnaur · 2018-11-28T12:54:36Z

I started a conversation about gomobile and modules here: https://groups.google.com/forum/#!topic/golang-dev/C0ip7pFC2Oc

One question I would like you to ponder on that thread is whether it would be acceptable to require gomobile users to first generate glue code with the gobind tool and then only let the gomobile tool do the final packaging.

gopherbot · 2019-03-12T16:51:59Z

Change https://golang.org/cl/167180 mentions this issue: all: add go.mod

gopherbot · 2019-03-12T16:52:00Z

Change https://golang.org/cl/167179 mentions this issue: all: set GO111MODULE=off explicitly in bind tests

Updates golang/go#27234 Updates golang/go#30228 Change-Id: Ibe281480398ff9d8c27657f399159885a75f646e Reviewed-on: https://go-review.googlesource.com/c/mobile/+/167179 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>

Commands run: go mod init go mod edit -go=1.11 go mod tidy go list -m all go test ./... Updates golang/go#30228 Updates golang/go#27234 Change-Id: Ibf3b104bfaa037e1a94a5327b5a56983d9744e73 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/167180 Reviewed-by: Brad Fitzpatrick <[email protected]> Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>

gopherbot · 2019-03-16T14:59:07Z

Change https://golang.org/cl/167659 mentions this issue: cmd/gomobile: explicitly disable modules

Gomobile doesn't support modules. Updates golang/go#27234 Change-Id: I426db1600eafd4a9ddc7eb239f5f264756f1ba35 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/167659 Reviewed-by: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>

mehrvarz · 2019-03-17T09:07:23Z

Hi, I use modules heavily in my projects. Unfortunately, this makes using gomobile rather difficult. When do you expect gomobile to support modules? Any updates on this?

hajimehoshi · 2019-03-17T09:27:34Z

I was wondering whether packages that use major versions like /v2 are available with go mobile or not.

golang/go#27234

chrisprobst · 2019-04-17T10:27:56Z

We also need this feature desperately!

balupton · 2019-04-18T00:14:23Z

Are there any workarounds for the meantime?

cryptix · 2019-04-18T06:37:17Z

@balupton / @chrisprobst: I use go mod vendor then switch GO111MODULE=off and build it as a regular vendored project.

torbenschinke · 2019-05-07T11:32:34Z

@balupton / @chrisprobst: We basically also use go mod vendor. However I've created a small tool (GoUp) which automates this process for us.

A replative path in go.mod works only in the directory of the go.mod. When creating go.mod for gobind, copying relative paths did not work since go.mod is in a different temporary directory. This CL fixes the issue to use Dir, which is an absolute path to the module, instead of Path. Updates golang/go#27234 Change-Id: Ib009ec508aa3ce3d092af14f921a57192feaac61 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/215421 Run-TryBot: Hajime Hoshi <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]>

hajimehoshi · 2020-01-23T02:51:46Z

Now all the problems I found have been fixed. Let's close this issue (I don't have the right to close this issue though), and file other issues when we find other problems.

agnivade · 2020-01-23T03:56:11Z

Great work @hajimehoshi !

TTy32 · 2020-02-17T12:37:32Z

Thanks a lot @hajimehoshi !

themartorana · 2020-02-17T14:20:14Z

Forgive my lack of understanding - will this ship with a particular version of Go? I see it’s still part of an “Unreleased” milestone.

mvdan · 2020-02-17T15:02:09Z

@themartorana x/mobile is a repository and a module that you can use today. It's not shipped with Go releases, nor does it follow its release schedule. If a new version of gomobile is out, you can use it with Go 1.13.8, just like you can use it with 1.14rc1.

This is a preparation to use Go modules at gomobile command. Updates golang/go#27234 Cherry picked from github.com/golang/mobile

This CL is a pure refactoring. This removes a global variable ctx, which is a build.Default. Before this change, ctx was used to keep build tags and its state affected go command executions. As the variable is mutable, the code was not readable. This changes introduces another global variable buildTags instead, but this is more consistent with other build flags, and this is immutable. Updates golang/go#27234 Conflict: cmd/gomobile/build.go Cherry picked from github.com/golang/mobile

Before this change, all the gomobile commands forced Go modules to be off internally, regardless of the current Go modules state. After this change, gomobile-init command follows the current Go modules state. The other gomobile commands are not changed. This is also a preparation to support Go modules in gomobile-bind and gomobile-build. Updates golang/go#27234 Cherry picked from github.com/golang/mobile

This CL enables Go modules at gomobile-build command. This CL is a counterpart for the change gomobile-bind: https://golang.org/cl/210380 Updates golang/go#27234 Cherry picked from github.com/golang/mobile

karalabe · 2020-03-16T17:49:07Z

@hajimehoshi Oh wow, so happy to see this closed. Buuut :D, I think I found a tiny case that could use some love. gomobile doesn't seem to cache binaries across builds. I have a dependency that takes 5-7 minutes to build for a single platform (https://github.com/ipsn/go-libtor), so for all 4, that's a whopping 30. That's acceptable if it gets reused for subsequent builds, but unfortunately currently it does not. Would it be possible to keep the build cache around?

hajimehoshi · 2020-03-16T18:13:29Z

Thanks.

gomobile doesn't seem to cache binaries across builds.

That's odd since gomobile just invokes go commands as usual and then module cache and build cache should be used.

I was wondering if my fix was the culprit of the issue you reported. Hasn't there been this issue before my fix?

karalabe · 2020-03-16T18:39:56Z

That's odd since gomobile just invokes go commands as usual and then module cache and build cache should be used.

Isn't gomobile using custom build and cache dirs? The packages are definitely downloaded into the tmp folder under gomobile-work-xxxxxxxx, new for every build.

Hasn't there been this issue before my fix?

I can't say, it's been a while since I picked up gomobile. Started doing it today. If you're looking for a painful repro, here's the code I just pushed https://github.com/coronanet/go-coronanet . Though it would possibly make sense to use something smaller to test than this monstrosity.

hajimehoshi · 2020-03-17T13:48:13Z

Isn't gomobile using custom build and cache dirs? The packages are definitely downloaded into the tmp folder under gomobile-work-xxxxxxxx, new for every build.

Aha, gobind, which is invoked by gomobile, generates a source code from Go packages for binding, and they are not cached indeed. Did you mean 'cache' of them?

hajimehoshi · 2020-03-17T13:49:16Z

I think the cache issue is not related to this issue #27234, so I'd be happy if you could file a new issue.

karalabe · 2020-03-17T16:02:43Z

I think the cache issue is not related to this issue #27234, so I'd be happy if you could file a new issue.

@hajimehoshi Done #37902

This is a preparation to use Go modules at gomobile command. Updates golang/go#27234 Cherry picked from github.com/golang/mobile

This CL is a pure refactoring. This removes a global variable ctx, which is a build.Default. Before this change, ctx was used to keep build tags and its state affected go command executions. As the variable is mutable, the code was not readable. This changes introduces another global variable buildTags instead, but this is more consistent with other build flags, and this is immutable. Updates golang/go#27234 Conflict: cmd/gomobile/build.go Cherry picked from github.com/golang/mobile

Before this change, all the gomobile commands forced Go modules to be off internally, regardless of the current Go modules state. After this change, gomobile-init command follows the current Go modules state. The other gomobile commands are not changed. This is also a preparation to support Go modules in gomobile-bind and gomobile-build. Updates golang/go#27234 Cherry picked from github.com/golang/mobile

This CL enables Go modules at gomobile-build command. This CL is a counterpart for the change gomobile-bind: https://golang.org/cl/210380 Updates golang/go#27234 Cherry picked from github.com/golang/mobile

gopherbot added this to the Unreleased milestone Aug 26, 2018

gopherbot added the mobile Android, iOS, and x/mobile label Aug 26, 2018

FiloSottile added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. modules labels Aug 30, 2018

iaburton mentioned this issue Dec 20, 2018

x/mobile: local import "." in non-local package #29368

Closed

eliasnaur mentioned this issue Dec 27, 2018

x/mobile: go1.12beta1 how to compile #29432

Closed

tiero mentioned this issue Jan 24, 2019

Error on building the latest master without GO111MODULE=on lightninglabs/neutrino#125

Closed

mvdan mentioned this issue Feb 1, 2019

Gobind fails when outside of $GOPATH #30047

Closed

agnivade mentioned this issue Feb 3, 2019

x/mobile: Does not work with go.mod replace #27324

Closed

anacrolix added a commit to anacrolix/torrent that referenced this issue Mar 22, 2019

Remove gomobile from CI

97e2332

golang/go#27234

agnivade closed this as completed Jan 23, 2020

itcuihao mentioned this issue Jan 24, 2020

GoCN每日新闻(2020-01-24) itcuihao/blog#525

Open

bcmills mentioned this issue Feb 5, 2020

x/mobile: build failing when using go modules #37048

Closed

zolia mentioned this issue Mar 3, 2020

CI: package:android fails to build mysteriumnetwork/node#1831

Closed

andydotxyz pushed a commit to fyne-io/fyne that referenced this issue Mar 5, 2020

cmd/gomobile: replace go/build with go/packages in gomobile-build

9070acd

This is a preparation to use Go modules at gomobile command. Updates golang/go#27234 Cherry picked from github.com/golang/mobile

karalabe mentioned this issue Mar 16, 2020

gomobile bind takes 30 mins, binaries not cached coronanet/go-coronanet#1

Open

karalabe mentioned this issue Mar 17, 2020

x/mobile: binding doens't seem to reuse build cache for modules #37902

Closed

OneOfOne mentioned this issue Mar 20, 2020

x/mobile: update documentation for module mode #37960

Closed

andydotxyz pushed a commit to fyne-io/fyne that referenced this issue Apr 5, 2020

cmd/gomobile: replace go/build with go/packages in gomobile-build

4a210bf

This is a preparation to use Go modules at gomobile command. Updates golang/go#27234 Cherry picked from github.com/golang/mobile

marceloneil mentioned this issue May 6, 2020

Migrate to Go Modules keybase/client#24023

Merged

40 tasks

golang locked and limited conversation to collaborators Mar 17, 2021

gopherbot added the FrozenDueToAge label Mar 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/mobile: build failing when using go modules #27234

x/mobile: build failing when using go modules #27234

mirza-s commented Aug 26, 2018

hajimehoshi commented Sep 10, 2018

wangyun commented Sep 19, 2018 •

edited

Loading

evenardo commented Oct 10, 2018

myitcv commented Nov 14, 2018

eliasnaur commented Nov 14, 2018 via email

kingwill101 commented Nov 28, 2018

eliasnaur commented Nov 28, 2018

eliasnaur commented Nov 28, 2018

gopherbot commented Mar 12, 2019

gopherbot commented Mar 12, 2019

gopherbot commented Mar 16, 2019

mehrvarz commented Mar 17, 2019

hajimehoshi commented Mar 17, 2019

chrisprobst commented Apr 17, 2019

balupton commented Apr 18, 2019

cryptix commented Apr 18, 2019

torbenschinke commented May 7, 2019

hajimehoshi commented Jan 23, 2020

agnivade commented Jan 23, 2020

TTy32 commented Feb 17, 2020

themartorana commented Feb 17, 2020

mvdan commented Feb 17, 2020

karalabe commented Mar 16, 2020

hajimehoshi commented Mar 16, 2020

karalabe commented Mar 16, 2020

hajimehoshi commented Mar 17, 2020

hajimehoshi commented Mar 17, 2020

karalabe commented Mar 17, 2020

x/mobile: build failing when using go modules #27234

x/mobile: build failing when using go modules #27234

Comments

mirza-s commented Aug 26, 2018

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

hajimehoshi commented Sep 10, 2018

wangyun commented Sep 19, 2018 • edited Loading

evenardo commented Oct 10, 2018

myitcv commented Nov 14, 2018

eliasnaur commented Nov 14, 2018 via email

kingwill101 commented Nov 28, 2018

eliasnaur commented Nov 28, 2018

eliasnaur commented Nov 28, 2018

gopherbot commented Mar 12, 2019

gopherbot commented Mar 12, 2019

gopherbot commented Mar 16, 2019

mehrvarz commented Mar 17, 2019

hajimehoshi commented Mar 17, 2019

chrisprobst commented Apr 17, 2019

balupton commented Apr 18, 2019

cryptix commented Apr 18, 2019

torbenschinke commented May 7, 2019

hajimehoshi commented Jan 23, 2020

agnivade commented Jan 23, 2020

TTy32 commented Feb 17, 2020

themartorana commented Feb 17, 2020

mvdan commented Feb 17, 2020

karalabe commented Mar 16, 2020

hajimehoshi commented Mar 16, 2020

karalabe commented Mar 16, 2020

hajimehoshi commented Mar 17, 2020

hajimehoshi commented Mar 17, 2020

karalabe commented Mar 17, 2020

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

wangyun commented Sep 19, 2018 •

edited

Loading