Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for kong 0.12 #10

Open
sohamkamani opened this issue Mar 7, 2018 · 1 comment
Open

Support for kong 0.12 #10

sohamkamani opened this issue Mar 7, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@sohamkamani
Copy link

Currently, the API we use to get targets, does not get targets with weight 0: https://github.com/gojekfarm/ping-kong/blob/master/kong.go#L71

According to kong 0.12, we need to use this API : /upstreams/{name or id}/targets/all/ (https://getkong.org/docs/0.12.x/admin-api/#endpoint)[https://getkong.org/docs/0.12.x/admin-api/#endpoint]

As a consequence of this, once an endpoint is marked as unhealthy, and a weight of 0 is set, it never appears again even if it becomes healthy

@rShetty
Copy link
Member

rShetty commented Mar 7, 2018

@sohamkamani We can add support for Kong 0.12, but 0.12 kong comes with its own built in health checker. We wanted this library to target mostly lower versions. But definitely adding support for 0.12 is in pipeline too

@rShetty rShetty added the enhancement New feature or request label Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants