Add missing error prints to format-specific load/save functions #99758
+36
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates the documentation. Note that this doesn't affect `load_from_file()` because it uses dynamic loaders, while these functions are wrappers around direct calls to functions defined inside modules without using the RresourceLoader API. Co-authored-by: Hugo Locurcio <[email protected]>
Mickeon
reviewed
Nov 27, 2024
| @@ -358,6 +358,7 @@ | |||
| <param index="0" name="buffer" type="PackedByteArray" /> | |||
| <description> | |||
| Loads an image from the binary contents of a JPEG file. | |||
| [b]Note:[/b] This method is only available in engine builds with the JPEG module enabled. By default, the JPEG module is enabled, but it can be disabled at build-time using the [code]module_jpg_enabled=no[/code] SCons option. | |||
There was a problem hiding this comment.
Suggested change
| [b]Note:[/b] This method is only available in engine builds with the JPEG module enabled. By default, the JPEG module is enabled, but it can be disabled at build-time using the [code]module_jpg_enabled=no[/code] SCons option. | |
| [b]Note:[/b] This method is only available in engine builds with the JPEG module, which is enabled by default. It can be disabled at build-time using the [code]module_jpg_enabled=no[/code] SCons option. |
Or similar? For the rest as well...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates the documentation.
Note that this doesn't affect
load_from_file()because it uses dynamic loaders, while these functions are wrappers around direct calls to functions defined inside modules without using the RresourceLoader API.