Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Clear Guides menu item when no guides exist #99742

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Disable Clear Guides menu item when no guides exist #99742

merged 1 commit into from
Nov 29, 2024
+11 −1

Conversation

timothyqiu
Copy link
Member

Clear Guides does nothing when there are no guides available.

clear_guides

@timothyqiu timothyqiu added this to the 4.x milestone Nov 27, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner November 27, 2024 06:00
Mickeon
Mickeon approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That we use get_meta alone to determine this is a bit weird but otherwise-

@KoBeWi KoBeWi modified the milestones: 4.x, 4.4 Nov 28, 2024
Calinou
Calinou approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@akien-mga akien-mga merged commit 7417a07 into godotengine:master Nov 29, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the clear-guides branch November 30, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

@KoBeWi KoBeWi KoBeWi approved these changes

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:2d usability
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@timothyqiu @akien-mga @Calinou @KoBeWi @Mickeon