Monitors tab incorrectly reports integers as floats

[clayjohn]

Tested versions

• Reproducible in latest master [0c45ace]

System information

M2 Macbook

Issue description

Values that are always integers are being reported as floats in the editor monitor.

This is technically a regression from #47502

However, #47502 just exposed an underlying flaw in the monitor system: get_monitor() always returns a double

godot/main/performance.cpp

Line 159 in 0c45ace

double Performance::get_monitor(Monitor p_monitor) const {

Steps to reproduce

Just look in the monitors tab

Minimal reproduction project (MRP)

N/A - this is native to the Godot editor itself

[carsonetb]

Hi!

I'd be interested in trying to fix this issue. I'm not sure if you've already started working on it, but if you haven't and you don't want to, I'd like to take a crack at it.

[clayjohn]

I don't plan on working on this, so go ahead!

[carsonetb]

I think the simplest way to fix this issue would be to just check if the number ends with a .0 and if so remove it. I just added a few lines to EditorPerformanceProfiler::_create_label which do this:

default: {
	String ret = TS->format_number(rtos(p_value));
	if (ret.ends_with(".0")) {
		ret = ret.pad_decimals(0);
	}
	return ret;
}

This fixes the issue of integers as floats in the Monitor:

By the way, I don't see how it's a flaw that get_monitor() returns a double. In 4.3 it returned a double but we didn't see the trailing ".0". Anyway, I'll probably create a pull request for this in a bit.

[AThousandShips]

This was already reported in:

• [4.4-dev4] Floats and decimal in UI when integers should be used #99000

[clayjohn]

Closing as a duplicate of #99000