Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCons detect configure removes LINKFLAGS added beforehand (eg. command line) #101186

Open
dekaravanhoc opened this issue Jan 6, 2025 · 1 comment · May be fixed by #101715
Open

SCons detect configure removes LINKFLAGS added beforehand (eg. command line) #101186

dekaravanhoc opened this issue Jan 6, 2025 · 1 comment · May be fixed by #101715
Assignees
@Repiteo
Labels
bug platform:windows regression topic:buildsystem
Milestone
4.4

Comments

@dekaravanhoc
Copy link

Tested versions

Reproducible: Master
Not Reproducible: 4.3

System information

Godot v4.4.dev (bb22257) - Windows 11 (build 22631) - Multi-window, 3 monitors - Vulkan (Mobile) - dedicated NVIDIA GeForce RTX 4070 (NVIDIA; 32.0.15.6603) - AMD Ryzen 7 3700X 8-Core Processor (16 threads)

Issue description

Hey,

building with SCons on Master does not respect linkflags in the command line anymore (4.3 is not a problem).
Thats the build command I use:
scons dev_build=yes use_mingw=yes use_llvm=yes dev_mode=yes compiledb=yes linkflags="-Wl,-pdb=" ccflags="-g -gcodeview"
And it does not add the linkflags anymore.

I could narrow it down to

godot/SConstruct

Line 616 in 1aaf20b

detect.configure(env)

Adding a linkflag parameter before is ignored and after not.
As this was already there in 4.3, I cannot exactly tell what brought up the behavior in the current master.

Steps to reproduce

Add env.Append(LINKFLAGS=["-Whatever"]) before:

godot/SConstruct

Line 616 in 1aaf20b

detect.configure(env)

It is removed.
Add env.Append(LINKFLAGS=["-Whatever"]) after the line and it is added.

Minimal reproduction project (MRP)
@github-project-automation github-project-automation bot moved this to For team assessment in Buildsystem Issue Triage Jan 6, 2025
@AThousandShips AThousandShips added this to the 4.4 milestone Jan 6, 2025
@akien-mga
Copy link
Member

akien-mga commented Jan 6, 2025 •
edited
Loading

Confirmed, that's a regression from #98105.

The env.Tool("mingw") added in this PR in the setup function resets flags, and then it just manually reparses 2 of the potential user-defined flags but not linkflags.

I'd question whether this change was necessary, this PR seems to add a number of hacks. (Not that it wasn't hacky before, but at least those were battle-tested hacks :P)

@akien-mga akien-mga moved this from Unassessed to Release Blocker in 4.x Release Blockers Jan 6, 2025
@akien-mga akien-mga moved this from Release Blocker to Very Bad in 4.x Release Blockers Jan 6, 2025
@Repiteo Repiteo linked a pull request Jan 17, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Repiteo Repiteo

Labels
bug platform:windows regression topic:buildsystem
Projects
4.x Release Blockers
Status: Very Bad
Buildsystem Issue Triage
Status: For team assessment
Milestone
4.4
Development

Successfully merging a pull request may close this issue.

SCons: Fix platform tool integration Repiteo/godot
4 participants
@akien-mga @Repiteo @dekaravanhoc @AThousandShips