Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4 Beta 1] Toggling the disabled property on CollisionShape3D with Jolt Physics will spam the area_entered signal #101695

Open
This-Gooch opened this issue Jan 17, 2025 · 4 comments · May be fixed by #101727

Comments

@This-Gooch
Copy link

This-Gooch commented Jan 17, 2025

Tested versions

Occurs on:

  • v4.4.beta1.mono.official [d33da79]

Does not occur on:

  • v4.4.dev7.mono.official [46c8f8c]

System information

Godot v4.4.beta1.mono - SteamOS holo on X11 - X11 display driver, Multi-window, 1 monitor - Vulkan (Forward+) - integrated AMD Custom GPU 0405 (RADV VANGOGH) - AMD Custom APU 0405 (8 threads)

Issue description

When the disabled property on CollisionShape3D is set from false to true while using Jolt Physics, any collision that happens shortly after will spam the area_entered signal.

Steps to reproduce

  1. Enable Jolt Physics from the Project Settings (Physics>3D)
  2. Add multiple Area3D nodes with CollisionShape3D nodes as children (Mesh3D as well for visibility)
  3. Add a script that will move the shapes through each other
  4. Run the project
  5. During runtime, toggle the Disabled property on the CollisionShape3D in the inspector

Note: You can script the disabled toggle behaviour as well, but through the inspector is how I reproduce it in the test project.

Minimal reproduction project (MRP)

CollisionShape3DDisabledPropertyJolt.zip

@AThousandShips
Copy link
Member

CC @mihe

@mihe mihe self-assigned this Jan 17, 2025
@mihe
Copy link
Contributor

mihe commented Jan 17, 2025

Looks to be a regression from #100983. I'll take a closer look.

@mihe mihe linked a pull request Jan 18, 2025 that will close this issue
@mihe
Copy link
Contributor

mihe commented Jan 18, 2025

Thankfully it turned out to be a silly one-liner fix: #101727

I appreciate the repro, @This-Gooch. I get the sense that this one might not have been easy for you to boil down.

@mihe mihe moved this from Unassessed to Release Blocker in 4.x Release Blockers Jan 18, 2025
@This-Gooch
Copy link
Author

Thanks a bunch! Was not too bad to track down since my current pipeline was pretty narrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Release Blocker
Development

Successfully merging a pull request may close this issue.

4 participants