Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unauthorized Access to pending Assets through enumeration #309

Open
moritztim opened this issue Nov 14, 2023 · 1 comment
Open

Unauthorized Access to pending Assets through enumeration #309

moritztim opened this issue Nov 14, 2023 · 1 comment
Labels

Comments

@moritztim
Copy link

moritztim commented Nov 14, 2023

https://godotengine.org/asset-library/asset/edit/9752 <- this has since been approved
You should not be able to see details of a pending asset. Yet you can, by following the link above. I could have found that link through enumeration, since the db uses incrementing numeric ids.

image
As you can see, I am not logged in, yet able to view this pending asset

@moritztim
Copy link
Author

This is a security risk in 2 scenarios:

  1. A malicious asset could be presented as legitimate since it's accessible on the official asset lib. There's nothing on the page to suggest that this is not approved.
  2. (less likely) A malicious actor finds a pending asset with sensitive info accidentally left in there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants