Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does the peer-to-peer branch seem to be deprecated? #384

Open
flyqie opened this issue May 3, 2024 · 5 comments · May be fixed by #399
Open

Why does the peer-to-peer branch seem to be deprecated? #384

flyqie opened this issue May 3, 2024 · 5 comments · May be fixed by #399

Comments

@flyqie
Copy link

flyqie commented May 3, 2024

Thanks to all the contributors to this project for their great work!

I'm trying to implement https://www.qemu.org/docs/master/interop/dbus-display.html in go

But the master branch of github.com/godbus/dbus does not seem to support p2p?

I found it in other branches, but it seems it has been abandoned (no updates nor merged to master in many years).

I don't quite understand why this is, any answers would be greatly appreciated!

@anonymix007 anonymix007 linked a pull request Dec 12, 2024 that will close this issue
@anonymix007
Copy link

Have you had any progress on this?

I've tried to implement this as well without much success. Basically everything seems to work except that the display listener methods were never called by QEMU.

@flyqie
Copy link
Author

flyqie commented Dec 14, 2024

Have you had any progress on this?

I've tried to implement this as well without much success. Basically everything seems to work except that the display listener methods were never called by QEMU.

I actually gave up on the pure go solution because it made my brain a mess :-( .

I have managed to use code modified from qemu's tests to implement the cgo solution, which doesn't work quite as well, but at least does what I need.

I'd be happy if you have any progress, I created a fork that includes your commit and the ancient p2p implementation mentioned in the issue (I eventually got the example working, although I couldn't use it to develop qemu-display).

https://github.com/flyqie/dbus.git

I hope the above content can help you at least a little bit, and I look forward to your final implementation of the pure go solution!

@anonymix007
Copy link

I think I got it working. At least I'm now seeing DisplayListener methods being called.

So it turns out that one has to first export the listener on the connection and only then register it within the console. Who would've guessed...

BTW, these P2P commits are basically adding support for acting as an auth server. And we don't need that for QEMU.

@flyqie
Copy link
Author

flyqie commented Dec 17, 2024

I think I got it working. At least I'm now seeing DisplayListener methods being called.

So it turns out that one has to first export the listener on the connection and only then register it within the console. Who would've guessed...

BTW, these P2P commits are basically adding support for acting as an auth server. And we don't need that for QEMU.

Hello, excuse me, what version of virt-manager are you using?

I still can't seem to find a version that can select dbus for vm display?

Currently, I can only connect directly to the system_bus, not the socket under unix:path=/run/libvirt/qemu/dbus/?

thanks!

@anonymix007
Copy link

what version of virt-manager are you using?

Latest in Arch, so should be 4.1.0-3

I still can't seem to find a version that can select dbus for vm display?

You can just type dbus there.

Note that while I kind of got it to show the picture on the screen, performance is awful.

BTW, we probably should continue this discussion here as it's not directly related to this repo anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants