Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to exclude API base classes #199

Open
maxrice opened this issue Mar 20, 2017 · 2 comments
Open

Option to exclude API base classes #199

maxrice opened this issue Mar 20, 2017 · 2 comments
Labels

Comments

@maxrice
Copy link
Contributor

maxrice commented Mar 20, 2017

As wonderful as the API base classes are, not every extension makes use of them. In an effort to slim down the size of the framework when included, we should add an initializer option for extensions to declare whether the API files should be loaded or not, similar to the payment gateway option.

@justinstern
Copy link
Contributor

we're going to run into the same chicken-and-egg problem that always comes up with trying to add functionality to the bootstrap class. This is something we're probably going to have to figure out a general solution for, one way or the other. Might end up being a matter of reworking the bootstrap class to support what we now know is needed, with some sort of one-time major backwards incompatible release, that forces people to either update all frameworked plugins and get the updated bootstrap, or deactivate older plugins

@bekarice
Copy link
Contributor

If we do consider this for a backwards-incompat fw release, perhaps considering #175 at the same time would be warranted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants