-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jQuery Phase 1 #1376
Remove jQuery Phase 1 #1376
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@AnthonyLedesma Found some odd behavior with the Gif block. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment about the Gif block resizing acting oddly. That's the only issue I found with it - good job!
@richtabor Good catch with the Gif block resizer. Fix has been pushed up. |
Description
Related to #1365. This PR removes jQuery from a few CoBlocks assets.
Types of changes
Seamless changes to codebase. This is an effort to remove jQuery from CoBlocks.
How has this been tested?
Tested re-written functionalities in Chrome, Firefox, Safari, Edge, and IE11.
Block tests pass.
Checklist: