Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery Phase 1 #1376

Merged
merged 14 commits into from
Mar 9, 2020
Merged

Remove jQuery Phase 1 #1376

merged 14 commits into from
Mar 9, 2020

Conversation

AnthonyLedesma
Copy link
Member

@AnthonyLedesma AnthonyLedesma commented Feb 24, 2020

Description

Related to #1365. This PR removes jQuery from a few CoBlocks assets.

  • Remove jQuery from Form block
    • Remove from Edit.js
  • Remove jQuery from Gif block
    • Switch to Fetch API
  • Remove jQuery from Crop Settings component/extension
    • Switch to Fetch API

Types of changes

Seamless changes to codebase. This is an effort to remove jQuery from CoBlocks.

How has this been tested?

Tested re-written functionalities in Chrome, Firefox, Safari, Edge, and IE11.
Block tests pass.

Checklist:

  • My code is tested
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@AnthonyLedesma AnthonyLedesma added [Type] Code Quality Relevant to improving the quality of our code [Status] Needs Review Tracking pull requests that need another set of eyes labels Feb 24, 2020
@AnthonyLedesma AnthonyLedesma self-assigned this Feb 24, 2020
@AnthonyLedesma AnthonyLedesma added [Status] In Progress Tracking issues with work in progress and removed [Status] Needs Review Tracking pull requests that need another set of eyes labels Feb 24, 2020
@AnthonyLedesma AnthonyLedesma added [Status] Needs Review Tracking pull requests that need another set of eyes and removed [Status] In Progress Tracking issues with work in progress labels Feb 24, 2020
@richtabor richtabor added this to the Next Release milestone Feb 24, 2020
@cypress
Copy link

cypress bot commented Feb 24, 2020



Test summary

5 0 0 0


Run details

Project CoBlocks
Status Passed
Commit 61db225
Started Mar 9, 2020 9:19 PM
Ended Mar 9, 2020 9:20 PM
Duration 00:55 💡
OS Linux Debian - 10.3
Browser Chrome 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@AnthonyLedesma AnthonyLedesma marked this pull request as ready for review February 24, 2020 15:20
src/blocks/form/edit.js Outdated Show resolved Hide resolved
src/blocks/gif/edit.js Outdated Show resolved Hide resolved
@jrtashjian jrtashjian modified the milestones: 1.22.0, Next Release Mar 5, 2020
@richtabor
Copy link
Contributor

@AnthonyLedesma Found some odd behavior with the Gif block.

Here's a screen recording from master:
master

And from the PR:
pr

Copy link
Contributor

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about the Gif block resizing acting oddly. That's the only issue I found with it - good job!

@AnthonyLedesma
Copy link
Member Author

@richtabor Good catch with the Gif block resizer. Fix has been pushed up.
gifFix

@richtabor richtabor merged commit 490e610 into master Mar 9, 2020
@richtabor richtabor deleted the remove-jquery branch March 9, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review Tracking pull requests that need another set of eyes [Type] Code Quality Relevant to improving the quality of our code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants