Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing properties in EventListResponse #89

Open
fpellet opened this issue Aug 13, 2022 · 1 comment
Open

Missing properties in EventListResponse #89

fpellet opened this issue Aug 13, 2022 · 1 comment

Comments

@fpellet
Copy link

fpellet commented Aug 13, 2022

Hello,

It is possible to include objects when retrieving the events list.
Except that the property is not set to EventListResponse and therefore it is not deserialized.

By example: EventListResponse.Linked.Payments of Payment list type.

Is it possible to add this? Where is the code generator defined so that I can make a PR directly?

@DanNoble-Spire
Copy link

Same issue here.

Calling the API directly we can do something like this: https://api-sandbox.gocardless.com/events?parent_event=<event_id>&resource_type=payments&include=payment

It returns payment events and payments:

image

The equivalent call using the NuGet package is

            var eventListRequest = new EventListRequest()
            {
                ParentEvent = <event_id>,
                ResourceType = EventListRequest.EventResourceType.Payments,
                Include = EventListRequest.EventInclude.Payment
            };
        
            EventListResponse eventListResponse = await _client.Events.ListAsync(eventListRequest);

This returns the payment events but it does not return the payment objects.

Can this be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants