Skip to content

Commit

Permalink
bugfix(gitlab): correct detailed merge status check (runatlantis#3067)
Browse files Browse the repository at this point in the history
  • Loading branch information
nitrocode authored and ijames-gc committed Feb 13, 2024
1 parent ef18724 commit a3804f0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion server/events/vcs/gitlab_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ func (g *GitlabClient) PullIsMergeable(repo models.Repo, pull models.PullRequest

isPipelineSkipped := mr.HeadPipeline.Status == "skipped"
allowSkippedPipeline := project.AllowMergeOnSkippedPipeline && isPipelineSkipped
if mr.DetailedMergeStatus == "mergeable" &&
if (mr.DetailedMergeStatus == "mergeable" || mr.DetailedMergeStatus == "ci_still_running") &&
mr.ApprovalsBeforeMerge <= 0 &&
mr.BlockingDiscussionsResolved &&
!mr.WorkInProgress &&
Expand Down

0 comments on commit a3804f0

Please sign in to comment.