Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove intermediate module definition in AffineEqualityAnalysis #1349

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

jerhard
Copy link
Member

@jerhard jerhard commented Feb 1, 2024

Clean up some relational code by making AffineEqualityDomain.D2 satisfy the RD signature directly. This allows removing a separate module definition in AffineEqualityAnalysis.

@jerhard jerhard added the cleanup Refactoring, clean-up label Feb 1, 2024
Copy link
Member

@sim642 sim642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this might cause some small conflicts for #1297 and #1330?

@michael-schwarz
Copy link
Member

I suppose this might cause some small conflicts for #1297 and #1330?

I guess so, yes. However hopefully these should be very easy to solve.

@jerhard jerhard merged commit 2878958 into master Feb 2, 2024
17 checks passed
@jerhard jerhard deleted the apron_cleanup branch February 2, 2024 09:27
@sim642 sim642 added this to the v2.4.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactoring, clean-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants