From 52b6fcca2091b26ddcab526444983bece37dbd5f Mon Sep 17 00:00:00 2001
From: benji-bitfly <174338202+benji-bitfly@users.noreply.github.com>
Date: Thu, 21 Nov 2024 15:33:27 +0100
Subject: [PATCH] feat(DashboardTableEfficiency): update `UI` for relative
 values in the `validator summary`

Display `-` when relative values are equal to 0.

See: BEDS-844
---
 frontend/.vscode/settings.json                |  1 +
 .../table/DashboardTableEfficiency.vue        | 23 +++++++++++--------
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/frontend/.vscode/settings.json b/frontend/.vscode/settings.json
index 4bac3b2e7..1afe95be7 100644
--- a/frontend/.vscode/settings.json
+++ b/frontend/.vscode/settings.json
@@ -11,6 +11,7 @@
     "BcToggle",
     "DashboardChartSummaryChartFilter",
     "DashboardGroupManagementModal",
+    "DashboardTableEfficiency",
     "DashboardTableSummaryDetails",
     "DashboardTableValidators",
     "DashboardValidatorManagmentModal",
diff --git a/frontend/components/dashboard/table/DashboardTableEfficiency.vue b/frontend/components/dashboard/table/DashboardTableEfficiency.vue
index e367a8d58..0c896df7c 100644
--- a/frontend/components/dashboard/table/DashboardTableEfficiency.vue
+++ b/frontend/components/dashboard/table/DashboardTableEfficiency.vue
@@ -38,20 +38,23 @@ const data = computed(() => {
       </slot>
     </template>
     <span v-if="absolute">
-      <BcFormatNumber
-        class="positive"
-        :value="props.success"
-      />
-      <span class="slash"> / </span>
-      <BcFormatNumber
-        :class="data.failedClass"
-        :value="props.failed"
-      />
+      <span v-if="props.success === 0 && props.failed === 0">-</span>
+      <template v-else>
+        <BcFormatNumber
+          class="positive"
+          :value="props.success"
+        />
+        <span class="slash"> / </span>
+        <BcFormatNumber
+          :class="data.failedClass"
+          :value="props.failed"
+        />
+      </template>
     </span>
     <BcFormatPercent
       v-else
       class="percent"
-      :base="data.sum"
+      :base="typeof data.sum === 'number' ? data.sum : undefined"
       :value="props.success"
       :fixed="undefined"
       :color-break-point="80"