Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support decoding binary tagged fields to byte slices #324

Open
galdor opened this issue Jan 29, 2018 · 4 comments
Open

Support decoding binary tagged fields to byte slices #324

galdor opened this issue Jan 29, 2018 · 4 comments

Comments

@galdor
Copy link

galdor commented Jan 29, 2018 •
edited
Loading

In the current state, base64-encoded fields tagged with !!binary can be decoded to strings, but not to byte slices: cannot unmarshal !!binary `XXXXX ...` into []uint8.

Could both string and []byte be supported ? It seems logical to allow storing binary data into []byte variables.
@galdor
Copy link
Author

galdor commented Mar 6, 2018

Is this package still maintained ?

@kpeu3i
Copy link

kpeu3i commented Mar 19, 2020

ping

It's really weird to store binary data in string...

@rick-kilgore rick-kilgore mentioned this issue Sep 12, 2023
Open
@rick-kilgore
Copy link

ping. I put up a PR for fixing this issue: #989

@rick-kilgore rick-kilgore mentioned this issue Sep 14, 2023
Open
@rick-kilgore
Copy link

rick-kilgore commented Sep 14, 2023 •
edited
Loading

Or if you prefer, here is the change against v2: #991. I'm really hoping these can get merged so I don't have to maintain them. @niemeyer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@galdor @rick-kilgore @kpeu3i