Skip to content
This repository has been archived by the owner on Aug 27, 2020. It is now read-only.

Should we merge mvt_provider and proviers config options. #4

Open
gdey opened this issue Jan 9, 2020 · 1 comment
Open

Should we merge mvt_provider and proviers config options. #4

gdey opened this issue Jan 9, 2020 · 1 comment

Comments

@gdey
Copy link
Member

gdey commented Jan 9, 2020

Should be remove mvt_provider, and have the provider register it's self as an mvt type of provider.

i.e.

[[mvtproviders]]
name = "test_postgis"       # provider name is referenced from map layers (required)
type = "postgis_mvt"            # the type of data provider must be "postgis" for this data provider (required)
host = "localhost"          # PostGIS database host (required)
port = 5432                 # PostGIS database port (required)
database = "tegola"         # PostGIS database name (required)
user = "tegola"             # PostGIS database user (required)
password = ""               # PostGIS database password (required)

There are some things to note about this approach.

  1. The provider needs to that it's an MVT provider (this could be done by look to see if it supports the mvt_provider interface)

  2. Documentation can be confusing as mvt providers can not conflate with other providers.

@ARolek
Copy link
Member

ARolek commented Jan 13, 2020

I think it would be ideal if we could just use the type property and not need to introduce a new top-level provider concept. It would also get rid of the mvt_ prefix that needs to be added to map layers.

Regarding conflation, we can't conflate at this time, but we have talked about ways to make conflating possible so it's not entirely a blocker long term.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants