Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashes on integrity attribute on archives are broken #792

Open
alexandru0-dev opened this issue Nov 29, 2023 · 0 comments
Open

Hashes on integrity attribute on archives are broken #792

alexandru0-dev opened this issue Nov 29, 2023 · 0 comments
Labels
type:bug Something isn't working

Comments

@alexandru0-dev
Copy link

Data

  • Shiori version: 1.5.4
  • Database Engine: sqlite
  • Operating system: NixOs
  • CLI/Web interface/Web Extension: 1.5.4 (served web-ui)

Describe the bug / actual behavior

When viewing the archived page, if the original webpage has an integrity attribute, the calculated hash is different from the hash of the original webpage, resulting in a missing resource.

Expected behavior / Possible Solution

Either replace the hash with the calculated one or remove the integrity attribute completely.

To Reproduce

Steps to reproduce the behavior:

  1. Add a link like: https://www.cloudhypervisor.org/
  2. Create archive for the link
  3. Open the archive page
@alexandru0-dev alexandru0-dev added the type:bug Something isn't working label Nov 29, 2023
@github-project-automation github-project-automation bot moved this to To do in Roadmap Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

1 participant