Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No image in ebook but in readable and archive mode #1011

Open
ynakao opened this issue Nov 14, 2024 · 0 comments
Open

No image in ebook but in readable and archive mode #1011

ynakao opened this issue Nov 14, 2024 · 0 comments
Labels
type:bug Something isn't working

Comments

@ynakao
Copy link

ynakao commented Nov 14, 2024

Data

  • Shiori version: Shiori version 1.7.1 (build 2315f0d) at 2024-10-05T20:33:28Z
  • Database Engine: SQLite
  • Operating system: Arch Linux
  • CLI/Web interface/Web Extension: Web interface

Describe the bug / actual behavior

When I bookmark this article (A look at the aerc mail client [LWN.net]), there's a image in both readable and archive view, but the downloaded epub file has no image.

Expected behavior

The image file is in the epub.

To Reproduce

Steps to reproduce the behavior:

  1. Add the LWN article link to Shiori.
  2. Click Download Book icon.
  3. Open the book.

Screenshots

In readable mode, the image is displayed properly.

shiori

When I open the book in zathura, there's a link to the image instead of the actual image.

zathura

When I open it in foliate, however, the image is displayed properly. Maybe foliate downloads the image? There's no image in the epub itself, anyway.

foliate

Notes

I tried inspecting the original article's HTML section regarding the image, it seems the href is not the direct link to the image, and the actual image is in the nested img tag. This causes the problem, I guess?

<blockquote>
  <a href="/Articles/993503">
    <img src="https://static.lwn.net/images/2024/aerc.png" alt="[The aerc mailer]" title="The
    aerc mailer" vspace="5" hspace="5" class="photo">
  </a>
</blockquote>
@ynakao ynakao added the type:bug Something isn't working label Nov 14, 2024
@github-project-automation github-project-automation bot moved this to To do in Roadmap Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

1 participant