Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Hole Falling Animation #161

Closed
KaratePikachu opened this issue Oct 31, 2024 · 2 comments · Fixed by #234
Closed

Create Hole Falling Animation #161

KaratePikachu opened this issue Oct 31, 2024 · 2 comments · Fixed by #234
Assignees
@KaratePikachu
Labels
Player Tasks related to the functionality of the player character World Tasks related to things that exist in the world

Comments

@KaratePikachu
Copy link
Contributor

The player currently is just teleported out of the hole. Add an animation that plays before moving the player out of the hole.
@KaratePikachu KaratePikachu added Player Tasks related to the functionality of the player character World Tasks related to things that exist in the world labels Oct 31, 2024
@DeaconBlues64 DeaconBlues64 self-assigned this Nov 7, 2024
@micycle8778 micycle8778 moved this from Unassigned to In Progress in Fetch Quest Fall 2024 Project Nov 7, 2024
@DeaconBlues64
Copy link
Contributor

Falling animation is in branch fallanim, being merged to hole-detector

@github-project-automation github-project-automation bot moved this from In Progress to Completed in Fetch Quest Fall 2024 Project Nov 7, 2024
@Justin1L8
Copy link
Contributor

I'm re-opening this issue for now. Initially I mentioned this and the hole relocation would be handled in the same PR, but since the relocation was finished earlier, that was already merged into main without this.
Update your branch from main (since the hole detector script was changed a lot) and make a new PR when you're done with the animation.

@Justin1L8 Justin1L8 reopened this Nov 13, 2024
@micycle8778 micycle8778 moved this from Completed to In Progress in Fetch Quest Fall 2024 Project Dec 20, 2024
@micycle8778 micycle8778 moved this from In Progress to Unassigned in Fetch Quest Fall 2024 Project Dec 20, 2024
@KaratePikachu KaratePikachu self-assigned this Dec 28, 2024
@micycle8778 micycle8778 moved this from Unassigned to In Progress in Fetch Quest Fall 2024 Project Dec 28, 2024
@KaratePikachu KaratePikachu mentioned this issue Dec 28, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Completed in Fetch Quest Fall 2024 Project Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KaratePikachu KaratePikachu

Labels
Player Tasks related to the functionality of the player character World Tasks related to things that exist in the world
Projects
Fetch Quest Fall 2024 Project
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Falling animation gmuGADIG/FetchQuest
3 participants
@Justin1L8 @KaratePikachu @DeaconBlues64