Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Enhancement #2

Open
SugaanthMohan opened this issue Jul 3, 2020 · 4 comments
Open

Performance Enhancement #2

SugaanthMohan opened this issue Jul 3, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@SugaanthMohan
Copy link

SugaanthMohan commented Jul 3, 2020

I am using your package and the code works great.
Thank you so much for your contribution.

And I was thinking that you could integrate your code with dataframe packages like pandas as well.

It could increase the code usage speed and by nature databases do tend to be huge, that could really bring your package to the next level.

A good Example would be :

Your current structure: (Dump.py)

self.entries = [] ( Existing List attribute )
self.entries.append( Entry(...) ) ( Existing Method)

Enhancement suggestion structure: (Dump.py)

import pandas as pd
self.dataset = pd.DataFrame() ( Similar Method )
self.dataset.append(Entry(...).__dict__) ( Similar Method )

Hope you get the idea. And thanks again for your contribution, you help developers like us make a living from coding. :)

@gmr
Copy link
Owner

gmr commented Jul 6, 2020

Thanks for this. I noticed you closed it, does that mean you changed your mind or?

@SugaanthMohan
Copy link
Author

It was by mistake, since I left a review from mobile.

@SugaanthMohan SugaanthMohan reopened this Jul 6, 2020
@gmr
Copy link
Owner

gmr commented Oct 1, 2020

So to integrate it with Pandas as a hard requirement is not something I'm keen to do, but I will keep it in mind from an optional perspective.

@gmr gmr added the enhancement New feature or request label Oct 1, 2020
@SugaanthMohan
Copy link
Author

Thanks GMR. My review was based on a real-time example that, when I used pgdumplib for a database with objects (not data) for a database around 600 MB.

It did take a good chunk of time for me to load them, and then again organise them so that i can perform my cherry picking and other operations. But none the less, this is an excellent tool for the future, Since I do not see such functionalities anywhere being provided for Postgresql.

Thanks for your consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants