Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewers are not saved properly on the main branch #2512

Closed
Carifio24 opened this issue Sep 5, 2024 · 4 comments
Closed

Viewers are not saved properly on the main branch #2512

Carifio24 opened this issue Sep 5, 2024 · 4 comments
Labels

Comments

@Carifio24
Copy link
Member

Carifio24 commented Sep 5, 2024

Describe the bug
Something very bad that I noticed - using glue-core off of the main branch of this repository, viewers are not properly restored from a Qt session.

To Reproduce
Use the current dev version of glue, together with the newest glue-qt:

  • pip install git+https://github.com/glue-viz/glue
  • pip install glue-qt

Expected behavior
Viewers should be saved into the session file

Screenshots
Here's a video of this in action
https://github.com/user-attachments/assets/f353c686-ddb4-420b-9362-3729037083d4

Details:

  • Operating System: Ubuntu 22.04
  • Python version: Python 3.11.9
  • Glue version: dev
  • How you installed glue: [e.g. conda or pip]

Additional context
Note that this works fine if I use the currently released version of glue-core. I would suspect #2510 as a possible cause, but to be honest I don't have a great handle on the serialization functionality as I've never really had a need to delve into it. Pinging @astrofrog in case he has thoughts on that.

@astrofrog
Copy link
Member

Can you try glue-core dev with glue-qt dev?

@Carifio24
Copy link
Member Author

It doesn't look like glue-qt has any new commits since the last release

@Carifio24
Copy link
Member Author

@astrofrog So I was using the newest release of glue-qt, which I assumed was 0.3.2 (which is up-to-date with the main branch there), but it looks like the newest version on PyPI is 0.3.1. I guess the release CI failed?

@Carifio24
Copy link
Member Author

I'll close this as things do work correctly using the dev versions of both packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants