From b12d66a59041b7b09a0861bc84a7c9be0381351e Mon Sep 17 00:00:00 2001 From: Jonathan Foster Date: Thu, 13 Jul 2023 17:04:12 -0400 Subject: [PATCH] Document why we don't use update_from_roi --- glue_jupyter/bqplot/common/tools.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/glue_jupyter/bqplot/common/tools.py b/glue_jupyter/bqplot/common/tools.py index 7003a7bd..8f7c21d5 100644 --- a/glue_jupyter/bqplot/common/tools.py +++ b/glue_jupyter/bqplot/common/tools.py @@ -204,10 +204,11 @@ def __init__(self, viewer, roi=None, finalize_callback=None, **kwargs): def update_from_roi(self, roi): """ - TOTO: This should update self.xlist and self.ylist from the existing ROI + While other tools allow the user to click and drag to reposition a selection, + this probably does not make sense for a polygonal selection, so we do not do + not support this. """ - with self.viewer._output_widget or nullcontext(): - pass + pass def activate(self): """