Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build, ci: upgrade build and ci setups #113

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

iisakkirotko
Copy link
Collaborator

@iisakkirotko iisakkirotko commented Dec 19, 2024

Pull Request Template

Description

Spiritual successor to #111. Does a few things

  • Migrates to a pyproject.toml based build process instead of a setup.py based one.
  • Bumps the NodeJS version on CI
  • Fixes visual regression tests
  • Fixes Python 3.7 tests

Todo:

  • Fix visual regression tests - failing due to a small change in how axis labels are rendered.
  • Python 3.6 tests need to be removed or modified - because hatch_jupyter_builder has only ever supported Python >= 3.7, we can't build on Python 3.6. However, any built wheel should also work on Python 3.6 so pre-building a wheel and then using it for py36 tests should work

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.44%. Comparing base (7b90b9d) to head (70dda5d).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   50.00%   44.44%   -5.56%     
==========================================
  Files           7        8       +1     
  Lines         140      189      +49     
==========================================
+ Hits           70       84      +14     
- Misses         70      105      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maartenbreddels maartenbreddels merged commit daeaca7 into glue-viz:main Dec 23, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants