Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angle (theta) support for some shapes #106

Open
pllim opened this issue Jan 2, 2024 · 1 comment
Open

Angle (theta) support for some shapes #106

pllim opened this issue Jan 2, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@pllim
Copy link
Contributor

pllim commented Jan 2, 2024

As mentioned in glue-viz/glue-jupyter#396 , in Jdaviz, when one draws a shape like rectangle or ellipse, and then gives it a non-zero angle, when you click on the shape to drag, there is a gray shadow (AFAIK controlled by this package) that does not understand non-zero angle.

As a result, we see a "gray" shadow that isn't rotated as we drag, but when we finalize the selection, the final shape has the desired rotation. This behavior is very confusing.

Desired outcome: bqplot object in JS to also understand angle (theta).

Example file: https://github.com/glue-viz/bqplot-image-gl/blob/main/js/lib/BrushEllipseSelector.js

@dhomeier
Copy link
Contributor

dhomeier commented Jan 2, 2024

Adding to the confusion, if one wants to resize, the pointer needs to be positioned at the edges/corners of the shadow area, not the rotated shape.
RectangularROI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants