XML elements are reordered, corrupting config.xml

[jkronborg]

Package version: 15.0.6

---

Steps to reproduce:

1. Create a Cordova project.
2. Add a privacy manifest to config.xml, e.g.:

   <?xml version='1.0' encoding='utf-8'?>
   <widget id="com.example.reproapp" version="1.0.0" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
       <name>ReproApp</name>
       <description>Sample Apache Cordova App</description>
       <author email="[email protected]" href="https://cordova.apache.org">
           Apache Cordova Team
       </author>
       <content src="index.html" />
       <allow-intent href="http://*/*" />
       <allow-intent href="https://*/*" />
       <platform name="ios">
           <privacy-manifest>
               <key>NSPrivacyTracking</key>
               <false />
               <key>NSPrivacyCollectedDataTypes</key>
               <array />
               <key>NSPrivacyAccessedAPITypes</key>
               <array />
               <key>NSPrivacyTrackingDomains</key>
               <array />
           </privacy-manifest>
       </platform>
   </widget>

3. Invoke cordova-set-version:

   cordova-set-version -b 123 config.xml

4. Observe that the privacy manifest has been corrupted, resulting in the app being rejected when submitted to App Store review:

   <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
   <widget id="com.example.reproapp" version="1.0.0" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0" android-versionCode="123" ios-CFBundleVersion="123" osx-CFBundleVersion="123">
     <name>ReproApp</name>
     <description>Sample Apache Cordova App</description>
     <author email="[email protected]" href="https://cordova.apache.org">
           Apache Cordova Team
       </author>
     <content src="index.html"/>
     <allow-intent href="http://*/*"/>
     <allow-intent href="https://*/*"/>
     <platform name="ios">
       <privacy-manifest>
         <key>NSPrivacyTracking</key>
         <key>NSPrivacyCollectedDataTypes</key>
         <key>NSPrivacyAccessedAPITypes</key>
         <key>NSPrivacyTrackingDomains</key>
         <false/>
         <array/>
         <array/>
         <array/>
       </privacy-manifest>
     </platform>
   </widget>

[SunboX]

Came across the same issue just now. :( @jkronborg could you figure out a work around?

[jkronborg]

Came across the same issue just now. :( @jkronborg could you figure out a work around?

@SunboX For the privacy manifest I created the PrivacyInfo.xcprivacy file separately and wrote a script that puts it in the right place, run as an after_prepare hook:

const fs = require('fs');
const path = require('path');

module.exports = function(context) {
    const projectRoot = context.opts.projectRoot;

    const manifestFilename = 'PrivacyInfo.xcprivacy';

    const manifestPathSrc = path.join(projectRoot, manifestFilename);

    const manifestPathDest = path.join(
        projectRoot,
        'platforms',
        'ios',
        '<AppName>',
        manifestFilename,
    );

    fs.copyFileSync(manifestPathSrc, manifestPathDest);
};

But that only helps if the privacy manifest is the only thing that the plugin corrupts.

[SunboX]

That's great! Thanks a lot!