Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Don't add build version numbers if they don't exist in config.xml #38

Open
FBNitro opened this issue Jun 8, 2017 · 3 comments
Assignees

Comments

@FBNitro
Copy link

FBNitro commented Jun 8, 2017

Would be nice to have a flag or individual options to not add the build number for specific operating systems to config.xml. For example, I currently don't use the android-versionCode, or osx-CFBundleVersion, I only use the ios-CFBundleVersion. I want android to use the version to construct the versionCode, instead of specifying it myself.

When I run the CLI, the android and osx versions are added in, but I don't want them added.

My original widget line:
<widget id="myapp" ios-CFBundleVersion="100" version="1.0.0" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">

CLI call:
cordova-set-version -v 1.0.2 -b 102

Resulting widget line:
<widget id="myapp" ios-CFBundleVersion="102" version="1.0.2" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0" android-versionCode="102" osx-CFBundleVersion="102">

@gligoran gligoran self-assigned this Jun 13, 2017
@gligoran
Copy link
Owner

This is an interesting idea and leads to a feature I thought about before - the ability to set build number per platform. So it wouldn't be about not adding new attributes, but about setting specific ones. That would open a lot more future options.

Unfortunately I don't have the time to undertake such a big change, but you're welcome to submit a PR.

@vesper8
Copy link

vesper8 commented Aug 17, 2020

@gligoran Would love to be able to set build numbers per platform and not automatically apply the build to all 3 platforms

I see you continue to maintain and develop this package, any chance you could look into adding this now?

Also, it would be nice if you could auto-increment the build and not have to pass it a value, if no value passed then it would just do +1 to whatever platform you designate

@gligoran
Copy link
Owner

Hey @vesper8.

Also, it would be nice if you could auto-increment the build and not have to pass it a value, if no value passed then it would just do +1 to whatever platform you designate

I see you've opened another issue for this, so I'll answer there (#267).

@gligoran Would love to be able to set build numbers per platform and not automatically apply the build to all 3 platforms

I see you continue to maintain and develop this package, any chance you could look into adding this now?

This is a good idea. I'm thinking about adding flags like [--ios-build-number|-bios], [--android-build-number|-ba], etc., which would set the version only for that specific platform, while [-b|--build-number] would still write in all of them.

I've just done some refactoring of the project that opens up the possibility of adding new arguments/flags, but still needs some further work. The main problem is that with each added argument the complexity of tests increases a lot and I need 100% coverage to be able to run automatic releases and automatic dependency updates.

I'll update this ticket when there some further updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants