Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Shortcuts Icons #86

Closed
6 tasks done
Tracked by #79
joshuajames-smith opened this issue Feb 3, 2022 · 0 comments · Fixed by #94
Closed
6 tasks done
Tracked by #79

Add Shortcuts Icons #86

joshuajames-smith opened this issue Feb 3, 2022 · 0 comments · Fixed by #94
Labels
feature [Improvement] New feature request.

Comments

@joshuajames-smith
Copy link
Contributor

joshuajames-smith commented Feb 3, 2022 •
edited
Loading

Problem

Relates to gliff-ai/roadmap#79.

Some keyboard keys have abbreviations, e.g. command > cmd and option > opt, but other keyboard keys do not, e.g. backspace and enter, and will not fit in the circle shortcuts design. Recognisable icons is the route to help solve this and enable the shortcuts update UI/UX design to be implemented.

Solution

Shortcut Icons

  • Upload shift-key, backspace-key + enter-key icon .svg files to style/src/assets/icons
  • Upload up-arrow, down-arrow, left-arrow + right-arrow icon .svg files to style/src/assets/icons
  • Upload help-center + keyboard-shortcut icon .svg files to style/src/assets/icons

  • Add shiftKey, backspaceKey + enterKey to icons.ts
  • Add upArrow, downArrow, leftArrow + rightArrow to icons.ts
  • Add helpCenter + keyboardShortcut to icons.ts

Considered Alternatives

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature [Improvement] New feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add Shortcuts Icons gliff-ai/style
1 participant
@joshuajames-smith