Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add Zoo #437

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

feat!: Add Zoo #437

wants to merge 24 commits into from

Conversation

SilviaZeta
Copy link
Contributor

@SilviaZeta SilviaZeta commented Jul 4, 2022

Description

  • make sort and search functionality reusable and export it from the repo.
  • re-style sort and search.
  • pass down the ZooDialog as prop and add it to the UI.
  • made group-by functionality in SortPopover optional.

closes #433
relates to gliff-ai/roadmap#82

Checklist:

Put an x in the boxes that apply to this pull request (you can also fill these out after opening the pull request). If you're unsure about any of these, don't hesitate to leave a comment on this pull request!

  • I have read the gliff.ai Contribution Guide.
  • I have requested to pull a branch and not from main.
  • I have checked all commit message styles match the requested structure.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my own code.
  • I have assigned 3 or less reviewers.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes generate no new warnings.
  • I have made corresponding changes to the documentation.
  • New database changes have been committed.
  • If appropriate, I have bumped any version numbers.

@SilviaZeta SilviaZeta changed the title feat!: Zoo feat!: Add Zoo Jul 4, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jul 4, 2022

This pull request fixes 1 alert when merging 26e1e44 into 958e367 - view on LGTM.com

fixed alerts:

  • 1 for Potentially inconsistent state update

@lgtm-com
Copy link

lgtm-com bot commented Jul 11, 2022

This pull request fixes 1 alert when merging dfbc34f into fcf4ff0 - view on LGTM.com

fixed alerts:

  • 1 for Potentially inconsistent state update

@SilviaZeta SilviaZeta self-assigned this Jul 12, 2022
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-437.westeurope.azurestaticapps.net

@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2022

This pull request fixes 1 alert when merging 020a04e into f1bed8d - view on LGTM.com

fixed alerts:

  • 1 for Potentially inconsistent state update

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-437.westeurope.azurestaticapps.net

@lgtm-com
Copy link

lgtm-com bot commented Jul 15, 2022

This pull request fixes 1 alert when merging 38b4c7d into f1bed8d - view on LGTM.com

fixed alerts:

  • 1 for Potentially inconsistent state update

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-437.westeurope.azurestaticapps.net

@lgtm-com
Copy link

lgtm-com bot commented Jul 15, 2022

This pull request fixes 1 alert when merging 0cafd9b into f1bed8d - view on LGTM.com

fixed alerts:

  • 1 for Potentially inconsistent state update

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-437.westeurope.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-437.westeurope.azurestaticapps.net

@lgtm-com
Copy link

lgtm-com bot commented Jul 29, 2022

This pull request fixes 1 alert when merging 9a64049 into ff767b7 - view on LGTM.com

fixed alerts:

  • 1 for Potentially inconsistent state update

@SilviaZeta SilviaZeta marked this pull request as ready for review July 29, 2022 10:50
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-meadow-05ee3f103-437.westeurope.azurestaticapps.net

@lgtm-com
Copy link

lgtm-com bot commented Aug 1, 2022

This pull request fixes 1 alert when merging 144d33a into e415d6f - view on LGTM.com

fixed alerts:

  • 1 for Potentially inconsistent state update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make search and sort reusable
2 participants