Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes label disappears and then reappears after a few seconds #294

Open
RoseBunker opened this issue Dec 15, 2021 · 1 comment
Open
Labels
bug [Problem] Something isn’t working or looking right.

Comments

@RoseBunker
Copy link

Describe the bug

Sometimes (like, maybe 1 in 6 times), I add a label to an image, it appears as a label added and then it disappears from the label box. After this happened half a dozen times, I then realized that the new label reappears after a few seconds, but the time in between is very confusing and I can’t tell if I did accurately label the image or not.

To Reproduce

Steps to reproduce the behaviour:

  1. Click the button in bottom left of thumbnail to add a label to an image
  2. Type in a label name and click +
  3. The new label shows below the 'new label' text box
  4. Wait
  5. The new label disappears
  6. Wait
  7. The new label reappears.

Expected behaviour

Not to disappear from view in label box.

Screenshots

Not provided.

System Info (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Browser version: 96.0.4664.93

Additional context

Not provided.

@RoseBunker RoseBunker added the bug [Problem] Something isn’t working or looking right. label Dec 15, 2021
@ChasNelson1990
Copy link
Member

I think this is caused by the following:

  1. User adds label
  2. DOMINATE sends first label to STORE
  3. User adds a different label
  4. DOMINATE sends second label to STORE
  5. STORE tells DOMINATE is has changes due to the first label so DOMINATE updates but because the second label hasn't made it to STORE yet that label is lost
  6. DOMINATE updates because of the second label so it reappears

Also, if you catch this at the wrong time, labels are just lost full-stop... given DOMINATE/CURATE temporarily remembers the added labels without STORE maybe we should not refresh DOMINATE/CURATE on label changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [Problem] Something isn’t working or looking right.
Projects
None yet
Development

No branches or pull requests

2 participants