Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strictNullChecks #678

Open
philipjackson opened this issue Feb 28, 2022 · 0 comments
Open

Enable strictNullChecks #678

philipjackson opened this issue Feb 28, 2022 · 0 comments
Labels
enhancement [Improvement] Enhancement request.

Comments

@philipjackson
Copy link
Contributor

We have strictNullChecks enabled in other repos but not this one. This has created problems at least once now (see #673 ), and strictNullChecks is considered good practice anyway, so we should do it, but it will create a lot of type errors we'll have to fix (198 when I last checked). Most of these will come down to adding | null to a bunch of types though so hopefully not too difficult.

We might wish to do this by moving tsconfig.json out into a separate repo, like we did with the eslint config.

@philipjackson philipjackson added the enhancement [Improvement] Enhancement request. label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [Improvement] Enhancement request.
Projects
None yet
Development

No branches or pull requests

1 participant