-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Can't import the named export" with TypeScript and yarn #852
Comments
I am having a similar problem when running jest tests.
|
i have the same question |
Sorry guys! I just exclude esm build in new version - so it should be fine, please let me know if you still have problems. Thanks! |
Wait, is this the right fix? Now ESM build is broken on latest Vite build with Searching around and this actually look like a bug with very outdated & deprecated build tool that have bug handling ESM module & package.json with the newer Some examples: facebook/react#20235 (comment) |
@tien Sorry, I didn't have much time to investigate the reason why it was broken. I'm thinking about the best way to handle it... I guess that I could include esm module back and publish new pre release 7, I would like to investigate the whole build directory, which is published through npm, cause I think that some of the files are unnecessary there. And after some period of time it can be latest release with updated readme. That's my thoughts |
No worries, I can just pin to version 6.5.1 for now. I don't think the library need to support deprecated build tools with bugs (i.e Webpack 4, cra, etc), which I suspect is the reason for the bugs people in this issue are getting. But it does make sense to do this as part of version 7, because it's technically a broken change since outdated build tool are no longer supported :p |
Just a heads up that we've needed to use
This is with a relatively modern version of vite ( Annoyingly, despite Typescript's own documentation, using |
Just wanted to say I've had the same issue, using webpack 5 as a bundler. Pinning to 6.5.1 for now. |
I try add library:
import CountUp from "react-countup";
and
import {default as CountUp} from "react-countup";
But i got error:
The text was updated successfully, but these errors were encountered: