Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check for exposing multiple modules on publish #3838

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: check for exposing multiple modules on publish #3838

wants to merge 1 commit into from
+96 −1

Conversation

Guria
Copy link

@Guria Guria commented Nov 16, 2024 •
edited
Loading

fixes #3834

reusing existing --yes flag to bypass new warning.

@Guria
Copy link
Author

Guria commented Nov 22, 2024

rebased to solve conflict in ci workflow file

lpil
lpil reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you! Couple small things inline

test/multi_namespace/src/foo.gleam Outdated Show resolved Hide resolved
compiler-cli/src/publish.rs Show resolved Hide resolved
@Guria
Copy link
Author

Guria commented Nov 27, 2024 •
edited
Loading

@lpil updated

Should I also use recently added cli::confirm_with_text method for this check as well?

lpil
lpil reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@lpil lpil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really nice! Left one comment inline

compiler-cli/src/publish.rs Outdated Show resolved Hide resolved
@Guria
Copy link
Author

Guria commented Nov 28, 2024 •
edited
Loading

@lpil updated

Question about cli::confirm_with_text is still relevant. Should I use it here or relying on --yes flag is ok here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpil lpil lpil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validate package with multiple top level module names on publish
2 participants
@Guria @lpil