-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cinnabar crashes with core dump rather than failing gracefully if upstream hg rejects push #338
Comments
Reproducer phrased as test case pushcrash.t attached. |
riastradh
pushed a commit
to riastradh/git-cinnabar
that referenced
this issue
Dec 9, 2024
This tests how git push to a remote hg repository reacts when hg crashes. Currently: by having git-cinnabar crash too. glandium#338
riastradh
pushed a commit
to riastradh/git-cinnabar
that referenced
this issue
Dec 9, 2024
If connection to upstream is hosed, consider nothing to have been pushed. fix glandium#338
riastradh
pushed a commit
to riastradh/git-cinnabar
that referenced
this issue
Dec 15, 2024
riastradh
pushed a commit
to riastradh/git-cinnabar
that referenced
this issue
Dec 15, 2024
If connection to upstream is hosed, consider nothing to have been pushed. fix glandium#338
riastradh
pushed a commit
to riastradh/git-cinnabar
that referenced
this issue
Dec 18, 2024
riastradh
pushed a commit
to riastradh/git-cinnabar
that referenced
this issue
Dec 18, 2024
If connection to upstream is hosed, consider nothing to have been pushed. fix glandium#338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Output:
Expected output: nothing involving unwrap on error value, no core dump, since the cause of the failed push is not (directly) a bug in Rust code but a refusal by the upstream repo.
The text was updated successfully, but these errors were encountered: