Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prosemirror support #970

Open
daknuett opened this issue Mar 2, 2021 · 5 comments · May be fixed by #1139
Open

Add prosemirror support #970

daknuett opened this issue Mar 2, 2021 · 5 comments · May be fixed by #1139

Comments

@daknuett
Copy link

daknuett commented Mar 2, 2021

  • OS Version: linux x86-64
  • Browser Version: Firefox 87.0
  • Browser Addon Version: 0.2.4
  • Neovim Plugin Version: 0.2.4
  • What I tried to do: Edit a file on my Nextcloud instance; the file was supposed to have several paragraphs.
  • What happened: after exiting firenvim (either using ZZ or :wq) the newlines (and thus the paragraphs) disappeared.

I added three shared files to reproduce the bug:

The files have different suffixes; it appears like the results depend on the file suffix.

@alerque
Copy link
Contributor

alerque commented Mar 3, 2021

Those Nextcloud links allow me to download the files, but I don't think they open the same editor view you are seeing. There is not place for Firenvim to be involved from an end users view without an account on your server (or a federated instance).

@daknuett
Copy link
Author

daknuett commented Mar 3, 2021

Hmm I tested it several times, you should be able to edit the links files exposed by those links. @glacambre tested it, too.

What browser are you using?

@alerque
Copy link
Contributor

alerque commented Mar 3, 2021

Firefox on Linux here. It's not presenting me much besides a download link. I even tried the "add to your Nextcloud", but it doesn't let me enter the address of my own Nextcloud instance and I assume it's limited to a federation whitelist of some sort.

image

@glacambre
Copy link
Owner

@alerque Very weird, I can access the documents, served under a prosemirror instance, and edit them in Firenvim with the dedicated browser shortcut.

Maybe your Firefox is too old or one of your extension is interfering?

@alerque
Copy link
Contributor

alerque commented Mar 4, 2021

No my Firefox is not too old and I checked extensions. Yes I did find the trouble. Firefox has a crazy pants way of (not) recovering from a few errors. At the time I first opened something on that domain the disk where my cache was was full. Firefox noted the error, but now even having cleared up 100+ Gigs on the cache disk, rebooted, restarted Firefox, and trying to refresh the site it keeps throwing an NS_ERROR_FILE_NO_DEVICE_SPACE error silently in the background.

This is not the site, Nextcloud, Firenvim, or any extension's fault: it is a known bug in Firefox that it doesn't recover from this error gracefully. I've run into it before on other sites and I think you have to manually clear local storage or something for the site to get it to recover. For the life of me I can't figure out what the magic sequence is right now. It works fine in private browsing mode but even with all extensions disabled and "clear site data and cookies" it still won't run in normal mode for me.

Relevant Firefox bug report (opened 7 years ago).

@glacambre glacambre changed the title Newlines sometimes disappear after saving file on Nextcloud 20.0.6 Add prosemirror support Mar 27, 2021
glacambre added a commit that referenced this issue Aug 30, 2021
@glacambre glacambre linked a pull request Aug 30, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants