diff --git a/ruby/ql/lib/codeql/ruby/frameworks/ActiveRecord.qll b/ruby/ql/lib/codeql/ruby/frameworks/ActiveRecord.qll index 0f30f2146df1..4db47cb83748 100644 --- a/ruby/ql/lib/codeql/ruby/frameworks/ActiveRecord.qll +++ b/ruby/ql/lib/codeql/ruby/frameworks/ActiveRecord.qll @@ -792,3 +792,36 @@ class ActiveRecordScopeCallTarget extends AdditionalCallTarget { ) } } + +/** Sinks for the mass assignment query. */ +private module MassAssignmentSinks { + private import codeql.ruby.security.MassAssignmentCustomizations + + pragma[nomagic] + private predicate massAssignmentCall(DataFlow::CallNode call, string name) { + call = activeRecordBaseClass().getAMethodCall(name) + or + call instanceof ActiveRecordInstanceMethodCall and + call.getMethodName() = name + } + + /** A call to a method that sets attributes of an database record using a hash. */ + private class MassAssignmentSink extends MassAssignment::Sink { + MassAssignmentSink() { + exists(DataFlow::CallNode call, string name | massAssignmentCall(call, name) | + name = + [ + "build", "create", "create!", "create_with", "create_or_find_by", "create_or_find_by!", + "find_or_create_by", "find_or_create_by!", "find_or_initialize_by", "insert", "insert!", + "insert_all", "insert_all!", "instantiate", "new", "update", "update!", "upsert", + "upsert_all" + ] and + this = call.getArgument(0) + or + // These methods have an optional first id parameter. + name = ["update", "update!"] and + this = call.getArgument(1) + ) + } + } +} diff --git a/ruby/ql/lib/codeql/ruby/security/MassAssignmentCustomizations.qll b/ruby/ql/lib/codeql/ruby/security/MassAssignmentCustomizations.qll new file mode 100644 index 000000000000..eeb7dc7056a7 --- /dev/null +++ b/ruby/ql/lib/codeql/ruby/security/MassAssignmentCustomizations.qll @@ -0,0 +1,98 @@ +/** + * Provides default sources, sinks, sanitizers, and flow steps for + * detecting insecure mass assignment, as well as extension points for adding your own. + */ + +private import codeql.ruby.AST +private import codeql.ruby.controlflow.CfgNodes +private import codeql.ruby.DataFlow +private import codeql.ruby.TaintTracking +private import codeql.ruby.dataflow.RemoteFlowSources + +/** + * Provides default sources, sinks, sanitizers, and flow steps for + * detecting insecure mass assignment, as well as extension points for adding your own. + */ +module MassAssignment { + /** + * A data flow source for user input used for mass assignment. + */ + abstract class Source extends DataFlow::Node { } + + /** + * A data flow sink for user input used for mass assignment. + */ + abstract class Sink extends DataFlow::Node { } + + /** + * A sanitizer for insecure mass assignment. + */ + abstract class Sanitizer extends DataFlow::Node { } + + /** + * A call that permits arbitrary parameters to be used for mass assignment. + */ + abstract class MassPermit extends DataFlow::Node { + /** Gets the argument for the parameters to be permitted. */ + abstract DataFlow::Node getParamsArgument(); + + /** Gets the result node of the permitted parameters. */ + abstract DataFlow::Node getPermittedParamsResult(); + } + + private class RemoteSource extends Source instanceof RemoteFlowSource { } + + /** A call to `permit!`, which permits each key of its receiver. */ + private class PermitBangCall extends MassPermit instanceof DataFlow::CallNode { + PermitBangCall() { this.(DataFlow::CallNode).getMethodName() = "permit!" } + + override DataFlow::Node getParamsArgument() { result = this.(DataFlow::CallNode).getReceiver() } + + override DataFlow::Node getPermittedParamsResult() { + result = this + or + result.(DataFlow::PostUpdateNode).getPreUpdateNode() = this.getParamsArgument() + } + } + + /** Holds if `h` is an empty hash or contains an empty hash at one if its (possibly nested) values. */ + private predicate hasEmptyHash(ExprCfgNode e) { + e instanceof ExprNodes::HashLiteralCfgNode and + not exists(e.(ExprNodes::HashLiteralCfgNode).getAKeyValuePair()) + or + hasEmptyHash(e.(ExprNodes::HashLiteralCfgNode).getAKeyValuePair().getValue()) + or + hasEmptyHash(e.(ExprNodes::PairCfgNode).getValue()) + or + hasEmptyHash(e.(ExprNodes::ArrayLiteralCfgNode).getAnArgument()) + } + + /** A call to `permit` that fully specifies the permitted parameters. */ + private class PermitCallSanitizer extends Sanitizer, DataFlow::CallNode { + PermitCallSanitizer() { + this.getMethodName() = "permit" and + not hasEmptyHash(this.getArgument(_).getExprNode()) + } + } + + /** A call to `permit` that uses an empty hash, which allows arbitrary keys to be specified. */ + private class PermitCallMassPermit extends MassPermit instanceof DataFlow::CallNode { + PermitCallMassPermit() { + this.(DataFlow::CallNode).getMethodName() = "permit" and + hasEmptyHash(this.(DataFlow::CallNode).getArgument(_).getExprNode()) + } + + override DataFlow::Node getParamsArgument() { result = this.(DataFlow::CallNode).getReceiver() } + + override DataFlow::Node getPermittedParamsResult() { result = this } + } + + /** A call to `to_unsafe_h`, which allows arbitrary parameter. */ + private class ToUnsafeHashCall extends MassPermit instanceof DataFlow::CallNode { + ToUnsafeHashCall() { this.(DataFlow::CallNode).getMethodName() = "to_unsafe_h" } + + override DataFlow::Node getParamsArgument() { result = this.(DataFlow::CallNode).getReceiver() } + + override DataFlow::Node getPermittedParamsResult() { result = this } + } +} diff --git a/ruby/ql/lib/codeql/ruby/security/MassAssignmentQuery.qll b/ruby/ql/lib/codeql/ruby/security/MassAssignmentQuery.qll new file mode 100644 index 000000000000..0d6bcd0a34f7 --- /dev/null +++ b/ruby/ql/lib/codeql/ruby/security/MassAssignmentQuery.qll @@ -0,0 +1,65 @@ +/** + * Provides a taint tracking configuration for reasoning about insecure mass assignment. + */ + +private import codeql.ruby.AST +private import codeql.ruby.DataFlow +private import codeql.ruby.TaintTracking +private import codeql.ruby.dataflow.RemoteFlowSources +private import MassAssignmentCustomizations + +private module FlowState { + private newtype TState = + TUnpermitted() or + TPermitted() + + /** A flow state used to distinguish whether arbitrary user parameters have been permitted to be used for mass assignment. */ + class State extends TState { + string toString() { + this = TUnpermitted() and result = "unpermitted" + or + this = TPermitted() and result = "permitted" + } + } + + /** A flow state used for user parameters for which arbitrary parameters have not been permitted to use for mass assignment. */ + class Unpermitted extends State, TUnpermitted { } + + /** A flow state used for user parameters for which arbitrary parameters have been permitted to use for mass assignment. */ + class Permitted extends State, TPermitted { } +} + +/** A flow configuration for reasoning about insecure mass assignment. */ +private module Config implements DataFlow::StateConfigSig { + class FlowState = FlowState::State; + + predicate isSource(DataFlow::Node node, FlowState state) { + node instanceof MassAssignment::Source and + state instanceof FlowState::Unpermitted + } + + predicate isSink(DataFlow::Node node, FlowState state) { + node instanceof MassAssignment::Sink and + state instanceof FlowState::Permitted + } + + predicate isBarrierIn(DataFlow::Node node, FlowState state) { isSource(node, state) } + + predicate isBarrierOut(DataFlow::Node node, FlowState state) { isSink(node, state) } + + predicate isBarrier(DataFlow::Node node) { node instanceof MassAssignment::Sanitizer } + + predicate isAdditionalFlowStep( + DataFlow::Node node1, FlowState state1, DataFlow::Node node2, FlowState state2 + ) { + exists(MassAssignment::MassPermit permit | + node1 = permit.getParamsArgument() and + state1 instanceof FlowState::Unpermitted and + node2 = permit.getPermittedParamsResult() and + state2 instanceof FlowState::Permitted + ) + } +} + +/** Taint tracking for reasoning about user input used for mass assignment. */ +module MassAssignmentFlow = TaintTracking::GlobalWithState; diff --git a/ruby/ql/src/change-notes/2024-03-22-mass-assignment.md b/ruby/ql/src/change-notes/2024-03-22-mass-assignment.md new file mode 100644 index 000000000000..566792cc5ae7 --- /dev/null +++ b/ruby/ql/src/change-notes/2024-03-22-mass-assignment.md @@ -0,0 +1,4 @@ +--- +category: newQuery +--- +* Added a new query, `rb/insecure-mass-assignment`, for finding instances of mass assignment operations accepting arbitrary parameters from remote user input. \ No newline at end of file diff --git a/ruby/ql/src/queries/security/cwe-915/MassAssignment.qhelp b/ruby/ql/src/queries/security/cwe-915/MassAssignment.qhelp new file mode 100644 index 000000000000..289f3a6a6ec1 --- /dev/null +++ b/ruby/ql/src/queries/security/cwe-915/MassAssignment.qhelp @@ -0,0 +1,34 @@ + + + +

+ Operations that allow for mass assignment (setting multiple attributes of an object using a hash), such as ActiveRecord::Base.new, should take care not to + allow arbitrary parameters to be set by the user. Otherwise, unintended attributes may be set, such as an is_admin field for a User object. +

+
+ +

+ When using a mass assignment operation from user supplied parameters, use ActionController::Parameters#permit to restrict the possible parameters + a user can supply, rather than ActionController::Parameters#permit!, which permits arbitrary parameters to be used for mass assignment. +

+
+ +

+ In the following example, permit! is used which allows arbitrary parameters to be supplied by the user. +

+ +

+ +

+

+ In the following example, only specific parameters are permitted, so the mass assignment is safe. +

+ +
+ + +
  • Rails guides: Strong Parameters.
  • +
    +
    diff --git a/ruby/ql/src/queries/security/cwe-915/MassAssignment.ql b/ruby/ql/src/queries/security/cwe-915/MassAssignment.ql new file mode 100644 index 000000000000..8e7e60b8850c --- /dev/null +++ b/ruby/ql/src/queries/security/cwe-915/MassAssignment.ql @@ -0,0 +1,20 @@ +/** + * @name Insecure Mass Assignment + * @description Using mass assignment with user-controlled attributes allows unintended parameters to be set. + * @kind path-problem + * @problem.severity error + * @security-severity 9.8 + * @precision high + * @id rb/insecure-mass-assignment + * @tags security + * external/cwe/cwe-915 + */ + +import codeql.ruby.security.MassAssignmentQuery +import MassAssignmentFlow::PathGraph + +from MassAssignmentFlow::PathNode source, MassAssignmentFlow::PathNode sink +where MassAssignmentFlow::flowPath(source, sink) +select sink.getNode(), source, sink, + "This mass assignment operation can assign user-controlled attributes from $@.", source.getNode(), + "this remote flow source" diff --git a/ruby/ql/src/queries/security/cwe-915/examples/MassAssignmentBad.rb b/ruby/ql/src/queries/security/cwe-915/examples/MassAssignmentBad.rb new file mode 100644 index 000000000000..2824be1850b1 --- /dev/null +++ b/ruby/ql/src/queries/security/cwe-915/examples/MassAssignmentBad.rb @@ -0,0 +1,10 @@ +class UserController < ActionController::Base + def create + # BAD: arbitrary params are permitted to be used for this assignment + User.new(user_params).save! + end + + def user_params + params.require(:user).permit! + end +end \ No newline at end of file diff --git a/ruby/ql/src/queries/security/cwe-915/examples/MassAssignmentGood.rb b/ruby/ql/src/queries/security/cwe-915/examples/MassAssignmentGood.rb new file mode 100644 index 000000000000..148afeb503a5 --- /dev/null +++ b/ruby/ql/src/queries/security/cwe-915/examples/MassAssignmentGood.rb @@ -0,0 +1,10 @@ +class UserController < ActionController::Base + def create + # GOOD: the permitted parameters are explicitly specified + User.new(user_params).save! + end + + def user_params + params.require(:user).permit(:name, :email) + end +end \ No newline at end of file diff --git a/ruby/ql/test/query-tests/security/cwe-915/MassAssignment.expected b/ruby/ql/test/query-tests/security/cwe-915/MassAssignment.expected new file mode 100644 index 000000000000..01c62c8ed215 --- /dev/null +++ b/ruby/ql/test/query-tests/security/cwe-915/MassAssignment.expected @@ -0,0 +1,84 @@ +edges +| test.rb:43:9:43:14 | call to params | test.rb:43:9:43:29 | call to require | provenance | | +| test.rb:43:9:43:29 | call to require | test.rb:43:9:43:37 | call to permit! | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:8:18:8:28 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:18:20:18:30 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:19:21:19:31 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:20:22:20:32 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:21:21:21:31 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:22:22:22:32 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:25:21:25:31 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:26:24:26:34 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:27:22:27:32 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:28:25:28:35 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:29:21:29:31 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:31:32:31:42 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:32:33:32:43 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:33:36:33:46 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:34:32:34:42 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:35:33:35:43 | call to user_params | provenance | | +| test.rb:43:9:43:37 | call to permit! | test.rb:36:26:36:36 | call to user_params | provenance | | +| test.rb:47:9:47:9 | x | test.rb:48:9:48:9 | x | provenance | | +| test.rb:47:13:47:18 | call to params | test.rb:47:13:47:25 | ...[...] | provenance | | +| test.rb:47:13:47:25 | ...[...] | test.rb:47:9:47:9 | x | provenance | | +| test.rb:48:9:48:9 | [post] x | test.rb:49:18:49:18 | x | provenance | | +| test.rb:48:9:48:9 | x | test.rb:48:9:48:9 | [post] x | provenance | | +| test.rb:51:18:51:23 | call to params | test.rb:51:18:51:40 | call to permit | provenance | | +| test.rb:52:18:52:23 | call to params | test.rb:52:18:52:69 | call to permit | provenance | | +| test.rb:53:18:53:23 | call to params | test.rb:53:18:53:35 | call to to_unsafe_h | provenance | | +nodes +| test.rb:8:18:8:28 | call to user_params | semmle.label | call to user_params | +| test.rb:18:20:18:30 | call to user_params | semmle.label | call to user_params | +| test.rb:19:21:19:31 | call to user_params | semmle.label | call to user_params | +| test.rb:20:22:20:32 | call to user_params | semmle.label | call to user_params | +| test.rb:21:21:21:31 | call to user_params | semmle.label | call to user_params | +| test.rb:22:22:22:32 | call to user_params | semmle.label | call to user_params | +| test.rb:25:21:25:31 | call to user_params | semmle.label | call to user_params | +| test.rb:26:24:26:34 | call to user_params | semmle.label | call to user_params | +| test.rb:27:22:27:32 | call to user_params | semmle.label | call to user_params | +| test.rb:28:25:28:35 | call to user_params | semmle.label | call to user_params | +| test.rb:29:21:29:31 | call to user_params | semmle.label | call to user_params | +| test.rb:31:32:31:42 | call to user_params | semmle.label | call to user_params | +| test.rb:32:33:32:43 | call to user_params | semmle.label | call to user_params | +| test.rb:33:36:33:46 | call to user_params | semmle.label | call to user_params | +| test.rb:34:32:34:42 | call to user_params | semmle.label | call to user_params | +| test.rb:35:33:35:43 | call to user_params | semmle.label | call to user_params | +| test.rb:36:26:36:36 | call to user_params | semmle.label | call to user_params | +| test.rb:43:9:43:14 | call to params | semmle.label | call to params | +| test.rb:43:9:43:29 | call to require | semmle.label | call to require | +| test.rb:43:9:43:37 | call to permit! | semmle.label | call to permit! | +| test.rb:47:9:47:9 | x | semmle.label | x | +| test.rb:47:13:47:18 | call to params | semmle.label | call to params | +| test.rb:47:13:47:25 | ...[...] | semmle.label | ...[...] | +| test.rb:48:9:48:9 | [post] x | semmle.label | [post] x | +| test.rb:48:9:48:9 | x | semmle.label | x | +| test.rb:49:18:49:18 | x | semmle.label | x | +| test.rb:51:18:51:23 | call to params | semmle.label | call to params | +| test.rb:51:18:51:40 | call to permit | semmle.label | call to permit | +| test.rb:52:18:52:23 | call to params | semmle.label | call to params | +| test.rb:52:18:52:69 | call to permit | semmle.label | call to permit | +| test.rb:53:18:53:23 | call to params | semmle.label | call to params | +| test.rb:53:18:53:35 | call to to_unsafe_h | semmle.label | call to to_unsafe_h | +subpaths +#select +| test.rb:8:18:8:28 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:8:18:8:28 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:18:20:18:30 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:18:20:18:30 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:19:21:19:31 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:19:21:19:31 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:20:22:20:32 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:20:22:20:32 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:21:21:21:31 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:21:21:21:31 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:22:22:22:32 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:22:22:22:32 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:25:21:25:31 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:25:21:25:31 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:26:24:26:34 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:26:24:26:34 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:27:22:27:32 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:27:22:27:32 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:28:25:28:35 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:28:25:28:35 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:29:21:29:31 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:29:21:29:31 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:31:32:31:42 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:31:32:31:42 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:32:33:32:43 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:32:33:32:43 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:33:36:33:46 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:33:36:33:46 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:34:32:34:42 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:34:32:34:42 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:35:33:35:43 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:35:33:35:43 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:36:26:36:36 | call to user_params | test.rb:43:9:43:14 | call to params | test.rb:36:26:36:36 | call to user_params | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:43:9:43:14 | call to params | this remote flow source | +| test.rb:49:18:49:18 | x | test.rb:47:13:47:18 | call to params | test.rb:49:18:49:18 | x | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:47:13:47:18 | call to params | this remote flow source | +| test.rb:51:18:51:40 | call to permit | test.rb:51:18:51:23 | call to params | test.rb:51:18:51:40 | call to permit | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:51:18:51:23 | call to params | this remote flow source | +| test.rb:52:18:52:69 | call to permit | test.rb:52:18:52:23 | call to params | test.rb:52:18:52:69 | call to permit | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:52:18:52:23 | call to params | this remote flow source | +| test.rb:53:18:53:35 | call to to_unsafe_h | test.rb:53:18:53:23 | call to params | test.rb:53:18:53:35 | call to to_unsafe_h | This mass assignment operation can assign user-controlled attributes from $@. | test.rb:53:18:53:23 | call to params | this remote flow source | diff --git a/ruby/ql/test/query-tests/security/cwe-915/MassAssignment.qlref b/ruby/ql/test/query-tests/security/cwe-915/MassAssignment.qlref new file mode 100644 index 000000000000..89dbc405a3ae --- /dev/null +++ b/ruby/ql/test/query-tests/security/cwe-915/MassAssignment.qlref @@ -0,0 +1 @@ +queries/security/cwe-915/MassAssignment.ql \ No newline at end of file diff --git a/ruby/ql/test/query-tests/security/cwe-915/test.rb b/ruby/ql/test/query-tests/security/cwe-915/test.rb new file mode 100644 index 000000000000..a60def5d201f --- /dev/null +++ b/ruby/ql/test/query-tests/security/cwe-915/test.rb @@ -0,0 +1,56 @@ +class User < ApplicationRecord + +end + +class UserController < ActionController::Base + def create + # BAD: arbitrary params are permitted to be used for this assignment + User.new(user_params).save! + end + + def create2 + # GOOD: the permitted parameters are explicitly specified + User.new(params[:user].permit(:name,:address)) + end + + def create3 + # each BAD + User.build(user_params) + User.create(user_params) + User.create!(user_params) + User.insert(user_params) + User.insert!(user_params) + User.insert_all([user_params]) + User.insert_all!([user_params]) + User.update(user_params) + User.update(7, user_params) + User.update!(user_params) + User.update!(7, user_params) + User.upsert(user_params) + User.upsert([user_params]) + User.find_or_create_by(user_params) + User.find_or_create_by!(user_params) + User.find_or_initialize_by(user_params) + User.create_or_find_by(user_params) + User.create_or_find_by!(user_params) + User.create_with(user_params) + + user = User.where(name:"abc") + user.update(user_params) + end + + def user_params + params.require(:user).permit! + end + + def create4 + x = params[:user] + x.permit! + User.new(x) # BAD + User.new(x.permit(:name,:address)) # GOOD + User.new(params.permit(user: {})) # BAD + User.new(params.permit(user: [:name, :address, {friends:{}}])) # BAD + User.new(params.to_unsafe_h) # BAD + User.new(params.permit(user: [:name, :address]).to_unsafe_h) # GOOD + end +end \ No newline at end of file