-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quoted terms are not detected as emphasis, in Japanese text #80
Comments
|
Hey, thanks for your issue. I believe this is an issue with the spec itself rather than our implementation, and I think there's already an open PR to the spec that should address this issue! Please see commonmark#208; it'd be helpful if you could add your voice to that PR to help it get momentum! |
(Here's some more discussion context: https://talk.commonmark.org/t/emphasis-and-east-asian-text/2491) |
Description
Generally I can emphasize a quoted term in English like as:
On the other hand, its translated version in Japanese is not emphasized same to above:
(Note:
前
meansbefore
「
(`\u300c*) is an open quoteフレーズ
meansphrase
」
(`\u300d*) is a close quote後
meansafter
)
Both English version and Japanese version examples should be parsed in the same way.
Steps to reproduce
git clone https://github.com/github/cmark.git
cd cmark
make
echo '前*「フレーズ」*後' | build/src/cmark-gfm
Expected result
<p>前<em>「フレーズ」</em>後</p>
Actual result
<p>前*「フレーズ」*後</p>
Details
It seems to be parsed based on the rule described at https://github.com/github/cmark/blob/master/test/spec.txt#L6346 :
However, in Japanese (and some other languages), terms are not separated with white spaces and emphasized quoted terms are generally written like as the example above.
The text was updated successfully, but these errors were encountered: