Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align behavior with Primer guidance behind validate-after-first-blur toggle #75

Closed
joelhawksley opened this issue Nov 21, 2024 · 0 comments · Fixed by #76
Closed

Align behavior with Primer guidance behind validate-after-first-blur toggle #75

joelhawksley opened this issue Nov 21, 2024 · 0 comments · Fixed by #76

Comments

@joelhawksley
Copy link
Contributor

joelhawksley commented Nov 21, 2024

In the Primer Forms documentation, it states:

Don't attempt to validate an input before the user is done with it. Validation may be performed as the user is typing or making their selection, but only after the first time the input has been validated and the input is in an invalid state. This gives the user early positive feedback by removing the error if the user makes a change that fixes it.

However, auto-check-element currently validates on every input change.

I recommend that we update the behavior to match the Primer documentation behind a toggle that defaults to false, validate our use-cases in GitHub.com to see if they all support this recommended behavior, then decide whether to leave it as a toggle long-term or to make it the default behavior, potentially with or without a fallback to the old behavior, which would be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant