-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch ApacheConf to maintained upstream #7143
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the documented method of changing grammars.
d98159d
to
5fad8d5
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script should have also created a yaml file containing the grammar licence. We need that file too. If it wasn't created or you've cleaned up, running just this line should do the trick:
Line 135 in 5fad8d5
bundle exec licensed cache -c vendor/licenses/config.yml |
d866976
to
5ecef2b
Compare
That's exactly what I did. What else is missing? |
See the test failures. They indicate the grammar may not have been swapped using the script as it should have prevented all of those issues as it updates all the files reported in those errors. |
So what happened appears to be that after running the script, three files got automatically staged whilst the licence and These I’ve now committed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. The grammars.yaml file has waaaaaaay too many changes.
caea533
to
1c7a57f
Compare
Sorry, fixed that! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vendor/README.md
should have also been updated by the script.
Description
Discussed in #7135.
Checklist: