This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
Change transform/cleanup signatures to accept *args, **kwargs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently transforms are expected to act solely on the state defined in their __init__ function. While this provides a clean interface, it may be too restrictive for some transforms (i.e. if a transform needs access to the task object that is calling it). Changing these signatures now hedges against making breaking changes to the API after there are a lot of these out in the wild.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently transforms are expected to act solely on the state defined
in their __init__ function. While this provides a clean interface, it
may be too restrictive for some transforms (i.e. if a transform needs
access to the task object that is calling it). Changing these
signatures now hedges against making breaking changes to the API after
there are a lot of these out in the wild.