Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Use localStorage instead of sessionStorage for OAuth Token #37

Open
giranm opened this issue Feb 2, 2022 · 0 comments
Open
Labels
enhancement New feature or request
Milestone

Comments

@giranm
Copy link
Owner

giranm commented Feb 2, 2022

Summary

The current implementation of PD Live persists the OAuth token to sessionStorage, which is valid for the lifecycle of a browser's tab. The suggested enhancement should use localStorage so that the users session remain active when the browser is restarted, while taking into account of the OAuth token TTL.

Affected Code

sessionStorage.setItem('pd_access_token', token);

@giranm giranm added the enhancement New feature or request label Feb 2, 2022
@giranm giranm added this to the Beta milestone Feb 28, 2022
@giranm giranm moved this to Todo in PagerDuty Live Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant