Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow expressInstall.swf for Flash versions < 10 #110

Open
andrewhavens opened this issue Feb 9, 2012 · 3 comments
Open

Allow expressInstall.swf for Flash versions < 10 #110

andrewhavens opened this issue Feb 9, 2012 · 3 comments

Comments

@andrewhavens
Copy link

I was having a hard time debugging why I couldn't get web-socket-js to work. Finally when I enabled debugging I realized that I had an older version of Flash installed. After looking through the code it looks like web-socket-js doesn't have a way to specify that you want to allow expressInstall for easy upgrades. Could this be improved so that we can specify a location of the expressInstall.swf if we want to allow this option?

@gimite
Copy link
Owner

gimite commented Feb 15, 2012

I didn't know about expressInstall.swf. What does it do? If you send a pull request adding support for it, I may pull it if it looks useful and not very complicated to integrate. BTW web-socket-js outputs error on console.error for known errors, including when Flash Player is < 10. So please check JavaScript console of the browser when you encounter any issues.

@andrewhavens
Copy link
Author

expressInstall.swf is a feature of Flash v6+ that swfobject.js supports. It provides an easy way for users to upgrade to the latest version of flash if they don't have the required version (in this case Flash 10+). Flash will prompt the user to upgrade and automatically install it.

I did eventually find the WEB_SOCKET_DEBUG = true.

I will see if I can add this feature and submit it as a pull request.

@gimite
Copy link
Owner

gimite commented Feb 17, 2012

expressInstall.swf is a feature of Flash v6+ that swfobject.js supports. It provides an easy way for users to upgrade to the latest version of flash if they don't have the required version (in this case Flash 10+). Flash will prompt the user to upgrade and automatically install it.

I see. Seems useful.

I did eventually find the WEB_SOCKET_DEBUG = true.

Error messages to console.error should be output regardless of WEB_SOCKET_DEBUG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants