Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab with file:/// URL breaks Tabox Open collection function #65

Open
Levertraan opened this issue Nov 1, 2023 · 2 comments
Open

Tab with file:/// URL breaks Tabox Open collection function #65

Levertraan opened this issue Nov 1, 2023 · 2 comments

Comments

@Levertraan
Copy link

Any tab with file:/// URL breaks Tabox Open collection function.
It skips those file:/// tabs (or cannot open them if (Discard tabs on open(Enabled))
Often this leads to groups being wholly or partially absent from the collection.
Generally http:// tabs will be present, but may be ungrouped.
Behaviour is not consistent; seems to truncate processing of collection on opening, particularly groups.

@SohamBiswas2007
Copy link

I tried it on Discard tabs on open(Disabled). I beleive a part of the problem is due to incorrect processing of URL. The extension adds an "&favicon=" at the end which may play a part in breaking the feature.

@kyletimmermans
Copy link

@Levertraan
@SohamBiswas2007 I thought the same thing, that by removing "&favicon=", would fix the issue. And it makes sense, because if you were to add that string to the end of any file:/// url, that would break it.

However, when we see the "&favicon=" in the url, this is actually only present for tabox's "Redirecting" page, the favicon string is only temporarily being stored there. The actual redirect removes the "&favicon=" string before the page is loaded (the file:/// URL).

The issue is that the "Redirecting" page doesn't have permission to open local file URLs, if you open the JavaScript console on that page for a file:/// URL, you'll see a "Not allowed to load local resource" error, and I believe this is the reason for the issues with any file:/// tabs.

I put in a PR to fix the issue: #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants